aboutsummaryrefslogtreecommitdiff
path: root/documentation/content/en/articles/committers-guide
diff options
context:
space:
mode:
authorWarner Losh <imp@FreeBSD.org>2021-06-16 22:14:34 +0000
committerWarner Losh <imp@FreeBSD.org>2021-06-16 22:14:34 +0000
commit8d6cf88d2faad4c9ce4c8e6e23ac041b42f969f4 (patch)
treeffdc963c23e0f9fdda94890f6281f63e41862dfd /documentation/content/en/articles/committers-guide
parent563afbd6f0ea882e4696f0f6c5c7d0256d0c3b79 (diff)
Diffstat (limited to 'documentation/content/en/articles/committers-guide')
-rw-r--r--documentation/content/en/articles/committers-guide/_index.adoc11
1 files changed, 11 insertions, 0 deletions
diff --git a/documentation/content/en/articles/committers-guide/_index.adoc b/documentation/content/en/articles/committers-guide/_index.adoc
index 9998694e0f..fffc6ef128 100644
--- a/documentation/content/en/articles/committers-guide/_index.adoc
+++ b/documentation/content/en/articles/committers-guide/_index.adoc
@@ -2329,6 +2329,17 @@ However, when there's multiple commits, especially when minor adjustments are ne
Briefly, these commands create a branch; cherry-picks the changes from the pull request; tests it; adjusts the commit messages; and fast forward merges it back to `main`.
The PR number is `$PR` below.
When adjusting the message, add `Pull Request: https://github.com/freebsd-src/pull/$PR`.
+[NOTE]
+======
+In addition, please check to make sure that the pull request author name is not anonymous.
+Github's web interface generates names like:
+[source,shell]
+....
+Author: github-user <38923459+github-user@users.noreply.github.com>
+....
+A polite request to the author for a better name and/or email should be made.
+======
+
[source,shell]
....
% git fetch github pull/$PR/head:staging