aboutsummaryrefslogtreecommitdiff
path: root/Tools
diff options
context:
space:
mode:
authorRene Ladan <rene@FreeBSD.org>2021-04-06 15:04:22 +0000
committerRene Ladan <rene@FreeBSD.org>2021-04-06 15:07:06 +0000
commit6d299fa340def7265630d8c2e8343b3bfaf7134b (patch)
tree922bb1609c2aa20086bc9942fbff5a345f6bb492 /Tools
parent1ec12d526fbb5f02bc1f2fdde47283c0598a0bf8 (diff)
downloadports-6d299fa340def7265630d8c2e8343b3bfaf7134b.tar.gz
ports-6d299fa340def7265630d8c2e8343b3bfaf7134b.zip
rmport: fix and simplify workflow
- gather information about the deleted port for the commit message before removing the port. I somehow missed that when testing the script. - Instead of a temporary branch, just operate on the current branch and incorporate upstream changes with git pull --rebase. This prevents one from being stranded on a temporary branch if the script crashes and oblivates the need for a squash merge [1] Suggested by: mat [1]
Diffstat (limited to 'Tools')
-rwxr-xr-xTools/scripts/rmport12
1 files changed, 3 insertions, 9 deletions
diff --git a/Tools/scripts/rmport b/Tools/scripts/rmport
index 221ff4d329b7..840bb2d5ddb5 100755
--- a/Tools/scripts/rmport
+++ b/Tools/scripts/rmport
@@ -339,9 +339,7 @@ commit()
${GIT} commit --file=${gitlog}
answer=$(ask "Do you want to merge and tweak the commit message")
if [ "${answer}" = "y" ] ; then
- ${GIT} checkout main 2>&1
- ${GIT} pull --ff-only 2>&1
- ${GIT} merge --squash ${branch} 2>&1 # history remains linear
+ ${GIT} pull --ff-only --rebase 2>&1
${GIT} commit 2>&1 # modify final commit message
echo "All done, check the result and push when everything is OK."
fi
@@ -352,8 +350,6 @@ cleanup()
log "cleaning up"
rm -f ${gitlog}
- ${GIT} checkout main
- ${GIT} branch -D ${branch}
}
usage()
@@ -430,8 +426,6 @@ if [ ${1} = "-a" ] ; then
exit
fi
-branch="rmport-$(date +%s)"
-${GIT} checkout -b ${branch} remotes/origin/main
gitlog=$(mktemp -t gitlog)
for catport in $* ; do
@@ -459,9 +453,9 @@ for catport in $* ; do
edit_Makefile ${cat} ${port}
- rm_port ${catport}
-
append_Template ${catport}
+
+ rm_port ${catport}
done
# give a chance to the committer to edit files by hand and recreate/review