diff options
| author | Tijl Coosemans <tijl@FreeBSD.org> | 2014-04-23 13:25:16 +0000 |
|---|---|---|
| committer | Tijl Coosemans <tijl@FreeBSD.org> | 2014-04-23 13:25:16 +0000 |
| commit | aad09bc5e23eb75a7a865a8b0002fbc6e13d4659 (patch) | |
| tree | 69c07cdc4812f0f8be0cc44c38513f540c058778 /multimedia/libtheora | |
| parent | 5c818b158c5b9479669f8322b4da8c48f5c30ef9 (diff) | |
| download | ports-aad09bc5e23eb75a7a865a8b0002fbc6e13d4659.tar.gz ports-aad09bc5e23eb75a7a865a8b0002fbc6e13d4659.zip | |
When linking a library libA with a library libB using libtool, if libB.la
exists, libtool will add all libraries libB.la refers to (dependency_libs
field) to the linker command line and store them in the dependency_libs
field of libA.la. So everything that subsequently links with libA will also
link to these extra libraries. This causes too much overlinking.
This commit modifies Mk/Uses/libtool.mk so it empties the dependency_libs
field in .la libraries during staging. However, because .la libraries have
very limited use when dependency_libs is empty it makes sense to completely
remove them during staging.
So with this commit USES=libtool is modified to remove .la libraries and a
new form (USES=libtool:keepla) is introduced in case they need to be kept
(dependency_libs is still emptied).
PORTREVISION is bumped on all ports with USES=libtool that install .la
libraries. Most ports are also changed to add :keepla because .la
libraries have to be kept around as long as there are dependent ports with
.la libraries that refer to them in their dependency_libs field. In most
cases :keepla can be removed again as soon as all dependent ports that
install .la libraries have some form of USES=libtool added to their
Makefile.
PR: ports/188759
Exp-run: bdrewery
Approved by: portmgr (bdrewery)
Notes
Notes:
svn path=/head/; revision=351936
Diffstat (limited to 'multimedia/libtheora')
| -rw-r--r-- | multimedia/libtheora/Makefile | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/multimedia/libtheora/Makefile b/multimedia/libtheora/Makefile index 3dabc9bb7969..cfe016173fe5 100644 --- a/multimedia/libtheora/Makefile +++ b/multimedia/libtheora/Makefile @@ -3,7 +3,7 @@ PORTNAME= libtheora PORTVERSION= 1.1.1 -PORTREVISION= 4 +PORTREVISION= 5 CATEGORIES= multimedia MASTER_SITES= http://downloads.xiph.org/releases/theora/ \ http://distfiles.master.finkmirrors.net/ @@ -13,8 +13,8 @@ COMMENT= Theora video codec for the Ogg multimedia streaming system LIB_DEPENDS= libvorbis.so:${PORTSDIR}/audio/libvorbis -USES= libtool GNU_CONFIGURE= yes +USES= libtool:keepla USE_BZIP2= yes USE_LDCONFIG= yes CONFIGURE_ENV= LIBS="${PTHEAD_LIBS}" |