diff options
author | Conrad Meyer <cem@FreeBSD.org> | 2020-03-09 01:53:13 +0000 |
---|---|---|
committer | Conrad Meyer <cem@FreeBSD.org> | 2020-03-09 01:53:13 +0000 |
commit | 747ea80263445ef7d5b8542609cadb1498be4ee5 (patch) | |
tree | f7ec8f091e02139f71f1dc2d51dec09597f2a021 /www/chromium | |
parent | 33ba71046db834f2b912f355ceedf26306477ba0 (diff) | |
download | ports-747ea80263445ef7d5b8542609cadb1498be4ee5.tar.gz ports-747ea80263445ef7d5b8542609cadb1498be4ee5.zip |
www/chromium: Reduce build log spam
Avoid build log spam by disabling a noisy and purely false-positive warning
in targeted locations. The Clang static analysis of pthread locking
primitives assumes they are not wrapped (as well as relatively simple
locking use). These headers simply wrap the underlying primitives and tickle
hundreds of false positives with deep include stacks that spam build logs.
Approved by: jrm
Differential Revision: https://reviews.freebsd.org/D24000
Notes
Notes:
svn path=/head/; revision=528087
Diffstat (limited to 'www/chromium')
-rw-r--r-- | www/chromium/files/patch-base_synchronization_lock__impl.h | 16 | ||||
-rw-r--r-- | www/chromium/files/patch-third__party_webrtc_rtc__base_third__party_sigslot_sigslot.h | 19 |
2 files changed, 35 insertions, 0 deletions
diff --git a/www/chromium/files/patch-base_synchronization_lock__impl.h b/www/chromium/files/patch-base_synchronization_lock__impl.h new file mode 100644 index 000000000000..fb3737a27ea9 --- /dev/null +++ b/www/chromium/files/patch-base_synchronization_lock__impl.h @@ -0,0 +1,16 @@ +--- base/synchronization/lock_impl.h.orig 2020-03-08 08:35:16 UTC ++++ base/synchronization/lock_impl.h +@@ -67,10 +67,13 @@ void LockImpl::Unlock() { + ::ReleaseSRWLockExclusive(reinterpret_cast<PSRWLOCK>(&native_handle_)); + } + #elif defined(OS_POSIX) || defined(OS_FUCHSIA) ++#pragma GCC diagnostic push ++#pragma GCC diagnostic ignored "-Wthread-safety-analysis" + void LockImpl::Unlock() { + int rv = pthread_mutex_unlock(&native_handle_); + DCHECK_EQ(rv, 0) << ". " << strerror(rv); + } ++#pragma GCC diagnostic pop + #endif + + // This is an implementation used for AutoLock templated on the lock type. diff --git a/www/chromium/files/patch-third__party_webrtc_rtc__base_third__party_sigslot_sigslot.h b/www/chromium/files/patch-third__party_webrtc_rtc__base_third__party_sigslot_sigslot.h new file mode 100644 index 000000000000..3d7e07133d72 --- /dev/null +++ b/www/chromium/files/patch-third__party_webrtc_rtc__base_third__party_sigslot_sigslot.h @@ -0,0 +1,19 @@ +--- third_party/webrtc/rtc_base/third_party/sigslot/sigslot.h.orig 2020-03-03 18:55:31 UTC ++++ third_party/webrtc/rtc_base/third_party/sigslot/sigslot.h +@@ -178,6 +178,8 @@ class multi_threaded_local { + #endif // _SIGSLOT_HAS_WIN32_THREADS + + #ifdef _SIGSLOT_HAS_POSIX_THREADS ++#pragma GCC diagnostic push ++#pragma GCC diagnostic ignored "-Wthread-safety-analysis" + // The multi threading policies only get compiled in if they are enabled. + class multi_threaded_global { + public: +@@ -201,6 +203,7 @@ class multi_threaded_local { + private: + pthread_mutex_t m_mutex; + }; ++#pragma GCC diagnostic pop + #endif // _SIGSLOT_HAS_POSIX_THREADS + + template <class mt_policy> |