aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJilles Tjoelker <jilles@FreeBSD.org>2014-07-05 21:50:59 +0000
committerJilles Tjoelker <jilles@FreeBSD.org>2014-07-05 21:50:59 +0000
commit2d70c637208e673f840791d7d6531cad630bd421 (patch)
treee6bd15f67118c878b7f1bdd679fb9cf42dd8cc67
parent764442e03dfc2a9d8b630bdab9b2f182fa9932f9 (diff)
Notes
-rw-r--r--bin/sh/miscbltin.c24
1 files changed, 14 insertions, 10 deletions
diff --git a/bin/sh/miscbltin.c b/bin/sh/miscbltin.c
index 27fa53db2fb4f..54b41cc83285f 100644
--- a/bin/sh/miscbltin.c
+++ b/bin/sh/miscbltin.c
@@ -414,7 +414,6 @@ static const struct limits limits[] = {
int
ulimitcmd(int argc __unused, char **argv __unused)
{
- int c;
rlim_t val = 0;
enum { SOFT = 0x1, HARD = 0x2 }
how = SOFT | HARD;
@@ -453,17 +452,22 @@ ulimitcmd(int argc __unused, char **argv __unused)
if (strcmp(p, "unlimited") == 0)
val = RLIM_INFINITY;
else {
- val = 0;
+ char *end;
+ uintmax_t uval;
- while ((c = *p++) >= '0' && c <= '9')
- {
- val = (val * 10) + (long)(c - '0');
- if (val < 0)
- break;
- }
- if (c)
+ if (*p < '0' || *p > '9')
+ error("bad number");
+ errno = 0;
+ uval = strtoumax(p, &end, 10);
+ if (errno != 0 || *end != '\0')
+ error("bad number");
+ if (uval > UINTMAX_MAX / l->factor)
+ error("bad number");
+ uval *= l->factor;
+ val = (rlim_t)uval;
+ if (val < 0 || (uintmax_t)val != uval ||
+ val == RLIM_INFINITY)
error("bad number");
- val *= l->factor;
}
}
if (all) {