diff options
| author | Ben Wilber <ben@desync.com> | 2024-05-10 02:08:15 +0000 |
|---|---|---|
| committer | Warner Losh <imp@FreeBSD.org> | 2024-05-10 02:08:18 +0000 |
| commit | 09025a7147084783bf1dd4d1bec463ceab8d16b4 (patch) | |
| tree | 8b94874a6ba12f365e4e7a678ff4938af8bd0b99 | |
| parent | 12be6f12e87abc3e1edd3cc6cdc20334bdd63380 (diff) | |
| download | src-09025a7147084783bf1dd4d1bec463ceab8d16b4.tar.gz src-09025a7147084783bf1dd4d1bec463ceab8d16b4.zip | |
ipfw: correctly report table manipulation errors
Let ipfw(8) report the actual error instead of the error that
may have come from calling printf().
Reviewed by: imp
Pull Request: https://github.com/freebsd/freebsd-src/pull/1221
| -rw-r--r-- | sbin/ipfw/tables.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/sbin/ipfw/tables.c b/sbin/ipfw/tables.c index 7901950acadd..4c783e02f856 100644 --- a/sbin/ipfw/tables.c +++ b/sbin/ipfw/tables.c @@ -1037,6 +1037,9 @@ table_modify_record(ipfw_obj_header *oh, int ac, char *av[], int add, } } + /* Get real OS error */ + error = errno; + /* Report results back */ ptent = tent_buf; for (i = 0; i < count; ptent++, i++) { @@ -1089,8 +1092,6 @@ table_modify_record(ipfw_obj_header *oh, int ac, char *av[], int add, if (error == 0) return; - /* Get real OS error */ - error = errno; /* Try to provide more human-readable error */ switch (error) { |