aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKonstantin Belousov <kib@FreeBSD.org>2021-07-22 10:27:43 +0000
committerKonstantin Belousov <kib@FreeBSD.org>2021-07-27 16:58:47 +0000
commit10db1896495b744aa5b039dd4ef1973b7a339379 (patch)
treeca32b038051a540485a33cc30da6c41207ad53c0
parent4f21442e10dbb22f1bd4c990dc0b1a2aa51231b9 (diff)
-rw-r--r--sys/fs/fifofs/fifo_vnops.c14
1 files changed, 13 insertions, 1 deletions
diff --git a/sys/fs/fifofs/fifo_vnops.c b/sys/fs/fifofs/fifo_vnops.c
index d2a51de84fba..861f1b40a744 100644
--- a/sys/fs/fifofs/fifo_vnops.c
+++ b/sys/fs/fifofs/fifo_vnops.c
@@ -282,9 +282,21 @@ fifo_close(ap)
struct pipe *cpipe;
vp = ap->a_vp;
+ ASSERT_VOP_ELOCKED(vp, "fifo_close");
fip = vp->v_fifoinfo;
+
+ /*
+ * During open, it is possible that the fifo vnode is relocked
+ * after the vnode is instantiated but before VOP_OPEN() is
+ * done. For instance, vn_open_vnode() might need to upgrade
+ * vnode lock, or ffs_vput_pair() needs to unlock vp to sync
+ * dvp. In this case, reclaim can observe us with v_fifoinfo
+ * equal to NULL.
+ */
+ if (fip == NULL)
+ return (0);
+
cpipe = fip->fi_pipe;
- ASSERT_VOP_ELOCKED(vp, "fifo_close");
if (ap->a_fflag & FREAD) {
fip->fi_readers--;
if (fip->fi_readers == 0) {