aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJohn Baldwin <jhb@FreeBSD.org>2011-09-16 17:41:56 +0000
committerJohn Baldwin <jhb@FreeBSD.org>2011-09-16 17:41:56 +0000
commitfb313e055bf89187af27c9c7f3750b2e7eef9a1e (patch)
treef46b3be0fdee6af995f3d10d3c097a9cddc584f8
parentea98915ebc864851432198b9294331ec59183fb6 (diff)
Notes
-rw-r--r--usr.bin/top/machine.c21
1 files changed, 4 insertions, 17 deletions
diff --git a/usr.bin/top/machine.c b/usr.bin/top/machine.c
index 19b93b7a7a3b..86025d509d36 100644
--- a/usr.bin/top/machine.c
+++ b/usr.bin/top/machine.c
@@ -622,7 +622,6 @@ get_process_info(struct system_info *si, struct process_select *sel,
int active_procs;
struct kinfo_proc **prefp;
struct kinfo_proc *pp;
- struct kinfo_proc *prev_pp = NULL;
/* these are copied out of sel for speed */
int show_idle;
@@ -655,7 +654,8 @@ get_process_info(struct system_info *si, struct process_select *sel,
}
previous_proc_count = nproc;
- pbase = kvm_getprocs(kd, KERN_PROC_ALL, 0, &nproc);
+ pbase = kvm_getprocs(kd, sel->thread ? KERN_PROC_ALL : KERN_PROC_PROC,
+ 0, &nproc);
if (nproc > onproc)
pref = realloc(pref, sizeof(*pref) * (onproc = nproc));
if (pref == NULL || pbase == NULL) {
@@ -725,21 +725,8 @@ get_process_info(struct system_info *si, struct process_select *sel,
/* skip proc. that don't belong to the selected UID */
continue;
- /*
- * When not showing threads, take the first thread
- * for output and add the fields that we can from
- * the rest of the process's threads rather than
- * using the system's mostly-broken KERN_PROC_PROC.
- */
- if (sel->thread || prev_pp == NULL ||
- prev_pp->ki_pid != pp->ki_pid) {
- *prefp++ = pp;
- active_procs++;
- prev_pp = pp;
- } else {
- prev_pp->ki_pctcpu += pp->ki_pctcpu;
- prev_pp->ki_runtime += pp->ki_runtime;
- }
+ *prefp++ = pp;
+ active_procs++;
}
/* if requested, sort the "interesting" processes */