diff options
| author | Conrad Meyer <cem@FreeBSD.org> | 2019-12-13 05:42:57 +0000 |
|---|---|---|
| committer | Conrad Meyer <cem@FreeBSD.org> | 2019-12-13 05:42:57 +0000 |
| commit | 23c30549affbe0343c01fd78998248956a246252 (patch) | |
| tree | ff7f9c43032da8b6c699cfec7c3160e4f732aa01 /contrib/telnet | |
| parent | 44d780e32b9d798a93b758fe0957d770e3190988 (diff) | |
| download | src-23c30549affbe0343c01fd78998248956a246252.tar.gz src-23c30549affbe0343c01fd78998248956a246252.zip | |
libtelnet: Replace bogus use of srandomdev + random to generate "public key pair"
I'm pretty skeptical that any crypto in telnet is worth using, but if we're
ostensibly generating keys, arc4random is strictly better than the previous
construct.
Notes
Notes:
svn path=/head/; revision=355699
Diffstat (limited to 'contrib/telnet')
| -rw-r--r-- | contrib/telnet/libtelnet/pk.c | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/contrib/telnet/libtelnet/pk.c b/contrib/telnet/libtelnet/pk.c index 29be15e5f8eb..a3d17f396c64 100644 --- a/contrib/telnet/libtelnet/pk.c +++ b/contrib/telnet/libtelnet/pk.c @@ -142,12 +142,7 @@ common_key(char *xsecret, char *xpublic, IdeaData *ideakey, DesData *deskey) static void getseed(char *seed, int seedsize) { - int i; - - srandomdev(); - for (i = 0; i < seedsize; i++) { - seed[i] = random() & 0xff; - } + arc4random_buf(seed, seedsize); } /* |