diff options
| author | Alan Somers <asomers@FreeBSD.org> | 2017-11-22 19:58:29 +0000 |
|---|---|---|
| committer | Alan Somers <asomers@FreeBSD.org> | 2017-11-22 19:58:29 +0000 |
| commit | 512bd18da5a0eab33f48b56327fb7812bb05e886 (patch) | |
| tree | f2ac67e18ab9d1b3b3b118bcec73a674fc954942 /lib/libcam | |
| parent | b0f662fed35704f8614e9b1d0328f8eea897a8d0 (diff) | |
| download | src-512bd18da5a0eab33f48b56327fb7812bb05e886.tar.gz src-512bd18da5a0eab33f48b56327fb7812bb05e886.zip | |
Add a test case for cam_get_device with sa(4) devices
sa(4) has some unique behavior that is special-cased in cam_get_device. The
existing tests don't provide coverage for this special case.
Reviewed by: ken
MFC after: 3 weeks
Sponsored by: Spectra Logic Corp
Differential Revision: https://reviews.freebsd.org/D13185
Notes
Notes:
svn path=/head/; revision=326101
Diffstat (limited to 'lib/libcam')
| -rw-r--r-- | lib/libcam/tests/libcam_test.c | 28 |
1 files changed, 28 insertions, 0 deletions
diff --git a/lib/libcam/tests/libcam_test.c b/lib/libcam/tests/libcam_test.c index 34eb52910037..71053beb9d3a 100644 --- a/lib/libcam/tests/libcam_test.c +++ b/lib/libcam/tests/libcam_test.c @@ -129,6 +129,33 @@ ATF_TC_BODY(cam_get_device_positive_test, tc) ATF_REQUIRE(parsed_unit == expected_unit); } +/* + * sa(4) uniquely creates nsa and esa device nodes for non-rewind operations + * and eject-on-close operations. cam_get_device must special case these nodes + * to always return the base device. + */ +ATF_TC_WITHOUT_HEAD(cam_get_device_sa_test); +ATF_TC_BODY(cam_get_device_sa_test, tc) +{ + char parsed_dev_name[DEV_IDLEN + 1]; + int parsed_unit; + + ATF_REQUIRE_MSG(cam_get_device("nsa99", parsed_dev_name, + nitems(parsed_dev_name), &parsed_unit) == 0, + "cam_get_device failed"); + ATF_REQUIRE_STREQ(parsed_dev_name, "sa"); + ATF_REQUIRE(parsed_unit == 99); + + strcpy(parsed_dev_name, ""); + parsed_unit = -1; + + ATF_REQUIRE_MSG(cam_get_device("esa99", parsed_dev_name, + nitems(parsed_dev_name), &parsed_unit) == 0, + "cam_get_device failed"); + ATF_REQUIRE_STREQ(parsed_dev_name, "sa"); + ATF_REQUIRE(parsed_unit == 99); +} + ATF_TC(cam_open_device_negative_test_O_RDONLY); ATF_TC_HEAD(cam_open_device_negative_test_O_RDONLY, tc) { @@ -282,6 +309,7 @@ ATF_TP_ADD_TCS(tp) ATF_TP_ADD_TC(tp, cam_get_device_negative_test_nul_path); ATF_TP_ADD_TC(tp, cam_get_device_negative_test_root); ATF_TP_ADD_TC(tp, cam_get_device_positive_test); + ATF_TP_ADD_TC(tp, cam_get_device_sa_test); ATF_TP_ADD_TC(tp, cam_open_device_negative_test_O_RDONLY); ATF_TP_ADD_TC(tp, cam_open_device_negative_test_nonexistent); ATF_TP_ADD_TC(tp, cam_open_device_negative_test_unprivileged); |