aboutsummaryrefslogtreecommitdiff
path: root/lib/libdevstat
diff options
context:
space:
mode:
authorKenneth D. Merry <ken@FreeBSD.org>2015-02-27 02:44:12 +0000
committerKenneth D. Merry <ken@FreeBSD.org>2015-02-27 02:44:12 +0000
commit999efd901b5130085620dc57dbaaa35647c782e1 (patch)
treeeaf116d350f4218c198b854fcd756d03f24e1109 /lib/libdevstat
parent020a6642102ff3affb14707b6abb0461c95fd568 (diff)
downloadsrc-999efd901b5130085620dc57dbaaa35647c782e1.tar.gz
src-999efd901b5130085620dc57dbaaa35647c782e1.zip
Notes
Diffstat (limited to 'lib/libdevstat')
-rw-r--r--lib/libdevstat/devstat.c24
1 files changed, 3 insertions, 21 deletions
diff --git a/lib/libdevstat/devstat.c b/lib/libdevstat/devstat.c
index ade87388c8e8..d52332bd5931 100644
--- a/lib/libdevstat/devstat.c
+++ b/lib/libdevstat/devstat.c
@@ -1487,22 +1487,9 @@ devstat_compute_statistics(struct devstat *current, struct devstat *previous,
*destld = 0.0;
break;
/*
- * This calculation is somewhat bogus. It simply divides
- * the elapsed time by the total number of transactions
- * completed. While that does give the caller a good
- * picture of the average rate of transaction completion,
- * it doesn't necessarily give the caller a good view of
- * how long transactions took to complete on average.
- * Those two numbers will be different for a device that
- * can handle more than one transaction at a time. e.g.
- * SCSI disks doing tagged queueing.
- *
- * The only way to accurately determine the real average
- * time per transaction would be to compute and store the
- * time on a per-transaction basis. That currently isn't
- * done in the kernel, and would only be desireable if it
- * could be implemented in a somewhat non-intrusive and high
- * performance way.
+ * Some devstat callers update the duration and some don't.
+ * So this will only be accurate if they provide the
+ * duration.
*/
case DSM_MS_PER_TRANSACTION:
if (totaltransfers > 0) {
@@ -1512,11 +1499,6 @@ devstat_compute_statistics(struct devstat *current, struct devstat *previous,
} else
*destld = 0.0;
break;
- /*
- * As above, these next two really only give the average
- * rate of completion for read and write transactions, not
- * the average time the transaction took to complete.
- */
case DSM_MS_PER_TRANSACTION_READ:
if (totaltransfersread > 0) {
*destld = totaldurationread;