aboutsummaryrefslogtreecommitdiff
path: root/lib/libutil
diff options
context:
space:
mode:
authorMariusz Zaborski <oshogbo@FreeBSD.org>2017-08-10 16:50:13 +0000
committerMariusz Zaborski <oshogbo@FreeBSD.org>2017-08-10 16:50:13 +0000
commit1a32b20594e8d2669645b5ec022f2809296b1e6a (patch)
treea1bc162b64f9d581c8742269e31662ab72287ff3 /lib/libutil
parent4f9612a321fcdfbb4cd6cefcb251e88d500fdb90 (diff)
downloadsrc-1a32b20594e8d2669645b5ec022f2809296b1e6a.tar.gz
src-1a32b20594e8d2669645b5ec022f2809296b1e6a.zip
Notes
Diffstat (limited to 'lib/libutil')
-rw-r--r--lib/libutil/pidfile.c30
1 files changed, 23 insertions, 7 deletions
diff --git a/lib/libutil/pidfile.c b/lib/libutil/pidfile.c
index 50d3a440729d..f5777f62b079 100644
--- a/lib/libutil/pidfile.c
+++ b/lib/libutil/pidfile.c
@@ -28,6 +28,7 @@
__FBSDID("$FreeBSD$");
#include <sys/param.h>
+#include <sys/capsicum.h>
#include <sys/file.h>
#include <sys/stat.h>
@@ -103,6 +104,7 @@ pidfile_open(const char *path, mode_t mode, pid_t *pidptr)
struct stat sb;
int error, fd, dirfd, dirlen, filenamelen, count;
struct timespec rqtp;
+ cap_rights_t caprights;
pfh = malloc(sizeof(*pfh));
if (pfh == NULL)
@@ -179,13 +181,18 @@ pidfile_open(const char *path, mode_t mode, pid_t *pidptr)
* to the proper descriptor.
*/
if (fstat(fd, &sb) == -1) {
- error = errno;
- unlinkat(dirfd, pfh->pf_filename, 0);
- close(dirfd);
- close(fd);
- free(pfh);
- errno = error;
- return (NULL);
+ goto failed;
+ }
+
+ if (cap_rights_limit(dirfd,
+ cap_rights_init(&caprights, CAP_UNLINKAT)) < 0 && errno != ENOSYS) {
+ goto failed;
+ }
+
+ if (cap_rights_limit(fd, cap_rights_init(&caprights, CAP_PWRITE,
+ CAP_FSTAT, CAP_FTRUNCATE)) < 0 &&
+ errno != ENOSYS) {
+ goto failed;
}
pfh->pf_dirfd = dirfd;
@@ -194,6 +201,15 @@ pidfile_open(const char *path, mode_t mode, pid_t *pidptr)
pfh->pf_ino = sb.st_ino;
return (pfh);
+
+failed:
+ error = errno;
+ unlinkat(dirfd, pfh->pf_filename, 0);
+ close(dirfd);
+ close(fd);
+ free(pfh);
+ errno = error;
+ return (NULL);
}
int