diff options
| author | Dag-Erling Smørgrav <des@FreeBSD.org> | 2023-08-04 16:08:21 +0000 |
|---|---|---|
| committer | Dag-Erling Smørgrav <des@FreeBSD.org> | 2023-08-04 16:08:37 +0000 |
| commit | acc7cf8641dcedad295ff0e569c3f3a28939ada0 (patch) | |
| tree | e0df195f1980f9810b4e945d60bf7751536f1165 /lib | |
| parent | 8e4aa6317eb8145a8a9f6a61e235d13302cd13e3 (diff) | |
| download | src-acc7cf8641dcedad295ff0e569c3f3a28939ada0.tar.gz src-acc7cf8641dcedad295ff0e569c3f3a28939ada0.zip | |
pam_krb5: Clarify a loop condition.
The closing parenthesis was in the wrong location, so instead of assigning the return value to krbret and then comparing it to zero, we were assigning the result of the comparison to krbret and then comparing that to zero. This has no practical significance since the value is not used after the loop terminates.
PR: 229719
Reviewed by: cy
Differential Revision: https://reviews.freebsd.org/D41299
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/libpam/modules/pam_krb5/pam_krb5.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/lib/libpam/modules/pam_krb5/pam_krb5.c b/lib/libpam/modules/pam_krb5/pam_krb5.c index 3c7976297ed2..378de46d769f 100644 --- a/lib/libpam/modules/pam_krb5/pam_krb5.c +++ b/lib/libpam/modules/pam_krb5/pam_krb5.c @@ -576,8 +576,7 @@ pam_sm_setcred(pam_handle_t *pamh, int flags, PAM_LOG("Prepared for iteration"); /* Copy the creds (should be two of them) */ - while ((krbret = krb5_cc_next_cred(pam_context, ccache_temp, - &cursor, &creds) == 0)) { + while (krb5_cc_next_cred(pam_context, ccache_temp, &cursor, &creds) == 0) { krbret = krb5_cc_store_cred(pam_context, ccache_perm, &creds); if (krbret != 0) { PAM_LOG_KRB5_ERR(pam_context, krbret, |