aboutsummaryrefslogtreecommitdiff
path: root/llvm/lib/CodeGen/DeadMachineInstructionElim.cpp
diff options
context:
space:
mode:
authorDimitry Andric <dim@FreeBSD.org>2023-02-11 12:38:04 +0000
committerDimitry Andric <dim@FreeBSD.org>2023-02-11 12:38:11 +0000
commite3b557809604d036af6e00c60f012c2025b59a5e (patch)
tree8a11ba2269a3b669601e2fd41145b174008f4da8 /llvm/lib/CodeGen/DeadMachineInstructionElim.cpp
parent08e8dd7b9db7bb4a9de26d44c1cbfd24e869c014 (diff)
Diffstat (limited to 'llvm/lib/CodeGen/DeadMachineInstructionElim.cpp')
-rw-r--r--llvm/lib/CodeGen/DeadMachineInstructionElim.cpp62
1 files changed, 15 insertions, 47 deletions
diff --git a/llvm/lib/CodeGen/DeadMachineInstructionElim.cpp b/llvm/lib/CodeGen/DeadMachineInstructionElim.cpp
index ce00be634e9a..e36db43567c5 100644
--- a/llvm/lib/CodeGen/DeadMachineInstructionElim.cpp
+++ b/llvm/lib/CodeGen/DeadMachineInstructionElim.cpp
@@ -12,6 +12,7 @@
#include "llvm/ADT/PostOrderIterator.h"
#include "llvm/ADT/Statistic.h"
+#include "llvm/CodeGen/LiveRegUnits.h"
#include "llvm/CodeGen/MachineFunctionPass.h"
#include "llvm/CodeGen/MachineRegisterInfo.h"
#include "llvm/CodeGen/TargetSubtargetInfo.h"
@@ -30,10 +31,9 @@ namespace {
class DeadMachineInstructionElim : public MachineFunctionPass {
bool runOnMachineFunction(MachineFunction &MF) override;
- const TargetRegisterInfo *TRI;
const MachineRegisterInfo *MRI;
const TargetInstrInfo *TII;
- BitVector LivePhysRegs;
+ LiveRegUnits LivePhysRegs;
public:
static char ID; // Pass identification, replacement for typeid
@@ -78,15 +78,14 @@ bool DeadMachineInstructionElim::isDead(const MachineInstr *MI) const {
for (const MachineOperand &MO : MI->operands()) {
if (MO.isReg() && MO.isDef()) {
Register Reg = MO.getReg();
- if (Register::isPhysicalRegister(Reg)) {
+ if (Reg.isPhysical()) {
// Don't delete live physreg defs, or any reserved register defs.
- if (LivePhysRegs.test(Reg) || MRI->isReserved(Reg))
+ if (!LivePhysRegs.available(Reg) || MRI->isReserved(Reg))
return false;
} else {
if (MO.isDead()) {
#ifndef NDEBUG
- // Baisc check on the register. All of them should be
- // 'undef'.
+ // Basic check on the register. All of them should be 'undef'.
for (auto &U : MRI->use_nodbg_operands(Reg))
assert(U.isUndef() && "'Undef' use on a 'dead' register is found!");
#endif
@@ -108,6 +107,13 @@ bool DeadMachineInstructionElim::isDead(const MachineInstr *MI) const {
bool DeadMachineInstructionElim::runOnMachineFunction(MachineFunction &MF) {
if (skipFunction(MF.getFunction()))
return false;
+
+ MRI = &MF.getRegInfo();
+
+ const TargetSubtargetInfo &ST = MF.getSubtarget();
+ TII = ST.getInstrInfo();
+ LivePhysRegs.init(*ST.getRegisterInfo());
+
bool AnyChanges = eliminateDeadMI(MF);
while (AnyChanges && eliminateDeadMI(MF))
;
@@ -116,27 +122,16 @@ bool DeadMachineInstructionElim::runOnMachineFunction(MachineFunction &MF) {
bool DeadMachineInstructionElim::eliminateDeadMI(MachineFunction &MF) {
bool AnyChanges = false;
- MRI = &MF.getRegInfo();
- TRI = MF.getSubtarget().getRegisterInfo();
- TII = MF.getSubtarget().getInstrInfo();
// Loop over all instructions in all blocks, from bottom to top, so that it's
// more likely that chains of dependent but ultimately dead instructions will
// be cleaned up.
for (MachineBasicBlock *MBB : post_order(&MF)) {
- // Start out assuming that reserved registers are live out of this block.
- LivePhysRegs = MRI->getReservedRegs();
-
- // Add live-ins from successors to LivePhysRegs. Normally, physregs are not
- // live across blocks, but some targets (x86) can have flags live out of a
- // block.
- for (const MachineBasicBlock *Succ : MBB->successors())
- for (const auto &LI : Succ->liveins())
- LivePhysRegs.set(LI.PhysReg);
+ LivePhysRegs.addLiveOuts(*MBB);
// Now scan the instructions and delete dead ones, tracking physreg
// liveness as we go.
- for (MachineInstr &MI : llvm::make_early_inc_range(llvm::reverse(*MBB))) {
+ for (MachineInstr &MI : make_early_inc_range(reverse(*MBB))) {
// If the instruction is dead, delete it!
if (isDead(&MI)) {
LLVM_DEBUG(dbgs() << "DeadMachineInstructionElim: DELETING: " << MI);
@@ -149,34 +144,7 @@ bool DeadMachineInstructionElim::eliminateDeadMI(MachineFunction &MF) {
continue;
}
- // Record the physreg defs.
- for (const MachineOperand &MO : MI.operands()) {
- if (MO.isReg() && MO.isDef()) {
- Register Reg = MO.getReg();
- if (Register::isPhysicalRegister(Reg)) {
- // Check the subreg set, not the alias set, because a def
- // of a super-register may still be partially live after
- // this def.
- for (MCSubRegIterator SR(Reg, TRI,/*IncludeSelf=*/true);
- SR.isValid(); ++SR)
- LivePhysRegs.reset(*SR);
- }
- } else if (MO.isRegMask()) {
- // Register mask of preserved registers. All clobbers are dead.
- LivePhysRegs.clearBitsNotInMask(MO.getRegMask());
- }
- }
- // Record the physreg uses, after the defs, in case a physreg is
- // both defined and used in the same instruction.
- for (const MachineOperand &MO : MI.operands()) {
- if (MO.isReg() && MO.isUse()) {
- Register Reg = MO.getReg();
- if (Register::isPhysicalRegister(Reg)) {
- for (MCRegAliasIterator AI(Reg, TRI, true); AI.isValid(); ++AI)
- LivePhysRegs.set(*AI);
- }
- }
- }
+ LivePhysRegs.stepBackward(MI);
}
}