aboutsummaryrefslogtreecommitdiff
path: root/sys/dev/aac
diff options
context:
space:
mode:
authorAttilio Rao <attilio@FreeBSD.org>2010-10-25 13:01:19 +0000
committerAttilio Rao <attilio@FreeBSD.org>2010-10-25 13:01:19 +0000
commit7897a432d77a2b6a8d42a1ea6a9445ef0ecc9818 (patch)
treef5b1b9baaeda9b450c8759ecde3741ae4dcc2cbd /sys/dev/aac
parentbfac4c4860bcc7affa0e88124ccfb507c3b09cbe (diff)
Notes
Diffstat (limited to 'sys/dev/aac')
-rw-r--r--sys/dev/aac/aac.c40
-rw-r--r--sys/dev/aac/aacvar.h3
2 files changed, 19 insertions, 24 deletions
diff --git a/sys/dev/aac/aac.c b/sys/dev/aac/aac.c
index de6973dceb35..bf528972b028 100644
--- a/sys/dev/aac/aac.c
+++ b/sys/dev/aac/aac.c
@@ -189,9 +189,9 @@ static char *aac_describe_code(struct aac_code_lookup *table,
/* Management Interface */
static d_open_t aac_open;
-static d_close_t aac_close;
static d_ioctl_t aac_ioctl;
static d_poll_t aac_poll;
+static void aac_cdevpriv_dtor(void *arg);
static int aac_ioctl_sendfib(struct aac_softc *sc, caddr_t ufib);
static int aac_ioctl_send_raw_srb(struct aac_softc *sc, caddr_t arg);
static void aac_handle_aif(struct aac_softc *sc,
@@ -214,7 +214,6 @@ static struct cdevsw aac_cdevsw = {
.d_version = D_VERSION,
.d_flags = D_NEEDGIANT,
.d_open = aac_open,
- .d_close = aac_close,
.d_ioctl = aac_ioctl,
.d_poll = aac_poll,
.d_name = "aac",
@@ -660,9 +659,6 @@ aac_detach(device_t dev)
sc = device_get_softc(dev);
fwprintf(sc, HBA_FLAGS_DBG_FUNCTION_ENTRY_B, "");
- if (sc->aac_state & AAC_STATE_OPEN)
- return(EBUSY);
-
callout_drain(&sc->aac_daemontime);
/* Remove the child containers */
@@ -2804,23 +2800,8 @@ aac_open(struct cdev *dev, int flags, int fmt, struct thread *td)
sc = dev->si_drv1;
fwprintf(sc, HBA_FLAGS_DBG_FUNCTION_ENTRY_B, "");
- sc->aac_open_cnt++;
- sc->aac_state |= AAC_STATE_OPEN;
-
- return 0;
-}
-
-static int
-aac_close(struct cdev *dev, int flags, int fmt, struct thread *td)
-{
- struct aac_softc *sc;
-
- sc = dev->si_drv1;
- fwprintf(sc, HBA_FLAGS_DBG_FUNCTION_ENTRY_B, "");
- sc->aac_open_cnt--;
- /* Mark this unit as no longer open */
- if (sc->aac_open_cnt == 0)
- sc->aac_state &= ~AAC_STATE_OPEN;
+ device_busy(sc->aac_dev);
+ devfs_set_cdevpriv(sc, aac_cdevpriv_dtor);
return 0;
}
@@ -3208,6 +3189,21 @@ out:
}
/*
+ * cdevpriv interface private destructor.
+ */
+static void
+aac_cdevpriv_dtor(void *arg)
+{
+ struct aac_softc *sc;
+
+ sc = arg;
+ fwprintf(sc, HBA_FLAGS_DBG_FUNCTION_ENTRY_B, "");
+ mtx_lock(&Giant);
+ device_unbusy(sc->aac_dev);
+ mtx_unlock(&Giant);
+}
+
+/*
* Handle an AIF sent to us by the controller; queue it for later reference.
* If the queue fills up, then drop the older entries.
*/
diff --git a/sys/dev/aac/aacvar.h b/sys/dev/aac/aacvar.h
index 3ecb262ca7eb..d89096b0e8b5 100644
--- a/sys/dev/aac/aacvar.h
+++ b/sys/dev/aac/aacvar.h
@@ -319,10 +319,9 @@ struct aac_softc
/* controller features, limits and status */
int aac_state;
#define AAC_STATE_SUSPEND (1<<0)
-#define AAC_STATE_OPEN (1<<1)
+#define AAC_STATE_UNUSED0 (1<<1)
#define AAC_STATE_INTERRUPTS_ON (1<<2)
#define AAC_STATE_AIF_SLEEPER (1<<3)
- int aac_open_cnt;
struct FsaRevision aac_revision;
/* controller hardware interface */