aboutsummaryrefslogtreecommitdiff
path: root/sys/dev
diff options
context:
space:
mode:
authorAndrew Turner <andrew@FreeBSD.org>2025-06-09 13:21:37 +0000
committerAndrew Turner <andrew@FreeBSD.org>2025-06-04 01:32:39 +0000
commitb65172cb9ebd704661dfa917e30af6658f8799f6 (patch)
treeec111ef2cdc3e9f8069d8b55a32d0c183ea39af9 /sys/dev
parent35fee38c77f1bb1a30a2c62b8eca923463dbed7e (diff)
Diffstat (limited to 'sys/dev')
-rw-r--r--sys/dev/firmware/arm/scmi.c24
-rw-r--r--sys/dev/firmware/arm/scmi.h1
2 files changed, 2 insertions, 23 deletions
diff --git a/sys/dev/firmware/arm/scmi.c b/sys/dev/firmware/arm/scmi.c
index 950bbf94eeb6..c24768a5668a 100644
--- a/sys/dev/firmware/arm/scmi.c
+++ b/sys/dev/firmware/arm/scmi.c
@@ -717,7 +717,7 @@ scmi_msg_put(device_t dev, struct scmi_msg *msg)
}
int
-scmi_request_tx(device_t dev, void *in)
+scmi_request(device_t dev, void *in, void **out)
{
struct scmi_softc *sc;
struct scmi_req *req;
@@ -732,11 +732,8 @@ scmi_request_tx(device_t dev, void *in)
/* Set inflight and send using transport specific method - refc-2 */
error = scmi_req_track_inflight(sc, req);
- if (error != 0) {
- device_printf(dev, "Failed to build req with HDR |%0X|\n",
- req->msg.hdr);
+ if (error != 0)
return (error);
- }
error = SCMI_XFER_MSG(sc->dev, &req->msg);
if (error != 0) {
@@ -744,22 +741,5 @@ scmi_request_tx(device_t dev, void *in)
return (error);
}
- return (0);
-}
-
-int
-scmi_request(device_t dev, void *in, void **out)
-{
- struct scmi_softc *sc;
- struct scmi_req *req;
- int error;
-
- error = scmi_request_tx(dev, in);
- if (error != 0)
- return (error);
-
- sc = device_get_softc(dev);
- req = buf_to_req(in);
-
return (scmi_wait_for_response(sc, req, out));
}
diff --git a/sys/dev/firmware/arm/scmi.h b/sys/dev/firmware/arm/scmi.h
index f5b4173272bb..f6aa072caeca 100644
--- a/sys/dev/firmware/arm/scmi.h
+++ b/sys/dev/firmware/arm/scmi.h
@@ -83,7 +83,6 @@ void scmi_buf_put(device_t dev, void *buf);
struct scmi_msg *scmi_msg_get(device_t dev, int tx_payld_sz, int rx_payld_sz);
void scmi_msg_put(device_t dev, struct scmi_msg *msg);
int scmi_request(device_t dev, void *in, void **);
-int scmi_request_tx(device_t dev, void *in);
void scmi_rx_irq_callback(device_t dev, void *chan, uint32_t hdr, uint32_t rx_len);
DECLARE_CLASS(scmi_driver);