diff options
| author | Mateusz Guzik <mjg@FreeBSD.org> | 2014-07-23 18:04:52 +0000 |
|---|---|---|
| committer | Mateusz Guzik <mjg@FreeBSD.org> | 2014-07-23 18:04:52 +0000 |
| commit | 6a1cf96b4a2dee29cf66887652e81ea2addc7821 (patch) | |
| tree | d28f26880fb83ad2f3505d5b585ae5d3b1900f40 /sys/kern/uipc_usrreq.c | |
| parent | ddd812b8500e99aee4d09f1a64a68b6ab118f8ff (diff) | |
| download | src-6a1cf96b4a2dee29cf66887652e81ea2addc7821.tar.gz src-6a1cf96b4a2dee29cf66887652e81ea2addc7821.zip | |
Cosmetic changes to unp_internalize
Don't throw away the result of fget_unlocked.
Move fdp increment to for loop to make it consistent with similar code
elsewhere.
MFC after: 1 week
Notes
Notes:
svn path=/head/; revision=269020
Diffstat (limited to 'sys/kern/uipc_usrreq.c')
| -rw-r--r-- | sys/kern/uipc_usrreq.c | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/sys/kern/uipc_usrreq.c b/sys/kern/uipc_usrreq.c index 6083983e7799..4ef2e685e5db 100644 --- a/sys/kern/uipc_usrreq.c +++ b/sys/kern/uipc_usrreq.c @@ -1853,7 +1853,7 @@ unp_internalize(struct mbuf **controlp, struct thread *td) struct filedescent *fde, **fdep, *fdev; struct file *fp; struct timeval *tv; - int i, fd, *fdp; + int i, *fdp; void *data; socklen_t clen = control->m_len, datalen; int error, oldfds; @@ -1906,14 +1906,13 @@ unp_internalize(struct mbuf **controlp, struct thread *td) */ fdp = data; FILEDESC_SLOCK(fdesc); - for (i = 0; i < oldfds; i++) { - fd = *fdp++; - if (fget_locked(fdesc, fd) == NULL) { + for (i = 0; i < oldfds; i++, fdp++) { + fp = fget_locked(fdesc, *fdp); + if (fp == NULL) { FILEDESC_SUNLOCK(fdesc); error = EBADF; goto out; } - fp = fdesc->fd_ofiles[fd].fde_file; if (!(fp->f_ops->fo_flags & DFLAG_PASSABLE)) { FILEDESC_SUNLOCK(fdesc); error = EOPNOTSUPP; |