diff options
| author | Jason A. Harmening <jah@FreeBSD.org> | 2023-01-16 20:07:19 +0000 |
|---|---|---|
| committer | Jason A. Harmening <jah@FreeBSD.org> | 2023-01-19 04:11:05 +0000 |
| commit | 5a4a83fd0e67a0d7787d2f3e09ef0e5552a1ffb6 (patch) | |
| tree | 1dddfa24ef60433f9ccf9660f061098a475c8f7a /sys/tools | |
| parent | 846e4a206fabf18b7ace01f6a41f65252da3dd95 (diff) | |
| download | src-5a4a83fd0e67a0d7787d2f3e09ef0e5552a1ffb6.tar.gz src-5a4a83fd0e67a0d7787d2f3e09ef0e5552a1ffb6.zip | |
Improve debuggability of VOP_* locking assertions
Include the phase and argument field to make it easier to determine
at a glance where the failure originated.
Reviewed by: kib, markj
Differential Revision: https://reviews.freebsd.org/D38091
Diffstat (limited to 'sys/tools')
| -rw-r--r-- | sys/tools/vnode_if.awk | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/sys/tools/vnode_if.awk b/sys/tools/vnode_if.awk index 486f0e6b2ce1..415c33c52420 100644 --- a/sys/tools/vnode_if.awk +++ b/sys/tools/vnode_if.awk @@ -73,14 +73,14 @@ function add_debug_code(name, arg, pos, ind) else star = ""; if (lockdata[name, arg, pos] && (lockdata[name, arg, pos] != "-")) { - printc(ind"ASSERT_VI_UNLOCKED("star"a->a_"arg", \""uname"\");"); + printc(ind"ASSERT_VI_UNLOCKED("star"a->a_"arg", \""uname" "pos" ("arg")\");"); # Add assertions for locking if (lockdata[name, arg, pos] == "L") - printc(ind"ASSERT_VOP_LOCKED(" star "a->a_"arg", \""uname"\");"); + printc(ind"ASSERT_VOP_LOCKED(" star "a->a_"arg", \""uname" "pos" ("arg")\");"); else if (lockdata[name, arg, pos] == "U") - printc(ind"ASSERT_VOP_UNLOCKED(" star "a->a_"arg", \""uname"\");"); + printc(ind"ASSERT_VOP_UNLOCKED(" star "a->a_"arg", \""uname" "pos" ("arg")\");"); else if (lockdata[name, arg, pos] == "E") - printc(ind"ASSERT_VOP_ELOCKED(" star "a->a_"arg", \""uname"\");"); + printc(ind"ASSERT_VOP_ELOCKED(" star "a->a_"arg", \""uname" "pos" ("arg")\");"); else if (0) { # XXX More checks! } |