aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--sys/kern/vfs_mount.c10
-rw-r--r--sys/kern/vfs_subr.c1
2 files changed, 3 insertions, 8 deletions
diff --git a/sys/kern/vfs_mount.c b/sys/kern/vfs_mount.c
index 55c62b7fe491..2fc98d3cc6c8 100644
--- a/sys/kern/vfs_mount.c
+++ b/sys/kern/vfs_mount.c
@@ -1095,14 +1095,6 @@ vfs_domount_first(
ASSERT_VOP_ELOCKED(vp, __func__);
KASSERT((fsflags & MNT_UPDATE) == 0, ("MNT_UPDATE shouldn't be here"));
- if ((fsflags & MNT_EMPTYDIR) != 0) {
- error = vfs_emptydir(vp);
- if (error != 0) {
- vput(vp);
- return (error);
- }
- }
-
/*
* If the jail of the calling thread lacks permission for this type of
* file system, or is trying to cover its own root, deny immediately.
@@ -1124,6 +1116,8 @@ vfs_domount_first(
error = vinvalbuf(vp, V_SAVE, 0, 0);
if (error == 0 && vp->v_type != VDIR)
error = ENOTDIR;
+ if (error == 0 && (fsflags & MNT_EMPTYDIR) != 0)
+ error = vfs_emptydir(vp);
if (error == 0) {
VI_LOCK(vp);
if ((vp->v_iflag & VI_MOUNT) == 0 && vp->v_mountedhere == NULL)
diff --git a/sys/kern/vfs_subr.c b/sys/kern/vfs_subr.c
index d4b7ac71eb97..181d0004e940 100644
--- a/sys/kern/vfs_subr.c
+++ b/sys/kern/vfs_subr.c
@@ -6300,6 +6300,7 @@ vfs_emptydir(struct vnode *vp)
eof = 0;
ASSERT_VOP_LOCKED(vp, "vfs_emptydir");
+ VNASSERT(vp->v_type == VDIR, vp, ("vp is not a directory"));
dirent = malloc(sizeof(struct dirent), M_TEMP, M_WAITOK);
iov.iov_base = dirent;