diff options
Diffstat (limited to 'lldb/source/Plugins/StructuredData/DarwinLog/StructuredDataDarwinLog.cpp')
| -rw-r--r-- | lldb/source/Plugins/StructuredData/DarwinLog/StructuredDataDarwinLog.cpp | 33 |
1 files changed, 12 insertions, 21 deletions
diff --git a/lldb/source/Plugins/StructuredData/DarwinLog/StructuredDataDarwinLog.cpp b/lldb/source/Plugins/StructuredData/DarwinLog/StructuredDataDarwinLog.cpp index b024854f3981..85366d3f9f4b 100644 --- a/lldb/source/Plugins/StructuredData/DarwinLog/StructuredDataDarwinLog.cpp +++ b/lldb/source/Plugins/StructuredData/DarwinLog/StructuredDataDarwinLog.cpp @@ -28,6 +28,7 @@ #include "lldb/Target/Process.h" #include "lldb/Target/Target.h" #include "lldb/Target/ThreadPlanCallOnFunctionExit.h" +#include "lldb/Utility/LLDBLog.h" #include "lldb/Utility/Log.h" #include "lldb/Utility/RegularExpression.h" @@ -958,7 +959,7 @@ public: }; EnableOptionsSP ParseAutoEnableOptions(Status &error, Debugger &debugger) { - Log *log = GetLogIfAllCategoriesSet(LIBLLDB_LOG_PROCESS); + Log *log = GetLog(LLDBLog::Process); // We are abusing the options data model here so that we can parse options // without requiring the Debugger instance. @@ -1062,7 +1063,7 @@ bool StructuredDataDarwinLog::SupportsStructuredDataType( void StructuredDataDarwinLog::HandleArrivalOfStructuredData( Process &process, ConstString type_name, const StructuredData::ObjectSP &object_sp) { - Log *log(lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_PROCESS)); + Log *log = GetLog(LLDBLog::Process); if (log) { StreamString json_stream; if (object_sp) @@ -1211,7 +1212,7 @@ void StructuredDataDarwinLog::SetEnabled(bool enabled) { void StructuredDataDarwinLog::ModulesDidLoad(Process &process, ModuleList &module_list) { - Log *log(lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_PROCESS)); + Log *log = GetLog(LLDBLog::Process); LLDB_LOGF(log, "StructuredDataDarwinLog::%s called (process uid %u)", __FUNCTION__, process.GetUniqueID()); @@ -1388,7 +1389,7 @@ Status StructuredDataDarwinLog::FilterLaunchInfo(ProcessLaunchInfo &launch_info, // done by adding an environment variable to the process on launch. (This // also means it is not possible to suppress this behavior if attaching to an // already-running app). - // Log *log(GetLogIfAnyCategoriesSet(LIBLLDB_LOG_PLATFORM)); + // Log *log = GetLog(LLDBLog::Platform); // If the target architecture is not one that supports DarwinLog, we have // nothing to do here. @@ -1466,7 +1467,7 @@ bool StructuredDataDarwinLog::InitCompletionHookCallback( // finishes and control returns to our new thread plan, that is the time when // we can execute our logic to enable the logging support. - Log *log(lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_PROCESS)); + Log *log = GetLog(LLDBLog::Process); LLDB_LOGF(log, "StructuredDataDarwinLog::%s() called", __FUNCTION__); // Get the current thread. @@ -1570,7 +1571,7 @@ bool StructuredDataDarwinLog::InitCompletionHookCallback( } void StructuredDataDarwinLog::AddInitCompletionHook(Process &process) { - Log *log(lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_PROCESS)); + Log *log = GetLog(LLDBLog::Process); LLDB_LOGF(log, "StructuredDataDarwinLog::%s() called (process uid %u)", __FUNCTION__, process.GetUniqueID()); @@ -1769,7 +1770,7 @@ size_t StructuredDataDarwinLog::HandleDisplayOfEvent( } void StructuredDataDarwinLog::EnableNow() { - Log *log(lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_PROCESS)); + Log *log = GetLog(LLDBLog::Process); LLDB_LOGF(log, "StructuredDataDarwinLog::%s() called", __FUNCTION__); // Run the enable command. @@ -1817,13 +1818,8 @@ void StructuredDataDarwinLog::EnableNow() { "enable command failed (process uid %u)", __FUNCTION__, process_sp->GetUniqueID()); } - // Report failures to the debugger error stream. - auto error_stream_sp = debugger_sp->GetAsyncErrorStream(); - if (error_stream_sp) { - error_stream_sp->Printf("failed to configure DarwinLog " - "support\n"); - error_stream_sp->Flush(); - } + Debugger::ReportError("failed to configure DarwinLog support", + debugger_sp->GetID()); return; } @@ -1851,13 +1847,8 @@ void StructuredDataDarwinLog::EnableNow() { "ConfigureStructuredData() call failed " "(process uid %u): %s", __FUNCTION__, process_sp->GetUniqueID(), error.AsCString()); - auto error_stream_sp = debugger_sp->GetAsyncErrorStream(); - if (error_stream_sp) { - error_stream_sp->Printf("failed to configure DarwinLog " - "support: %s\n", - error.AsCString()); - error_stream_sp->Flush(); - } + Debugger::ReportError("failed to configure DarwinLog support", + debugger_sp->GetID()); m_is_enabled = false; } else { m_is_enabled = true; |
