diff options
Diffstat (limited to 'sys/dev/sbni')
-rw-r--r-- | sys/dev/sbni/if_sbni.c | 5 | ||||
-rw-r--r-- | sys/dev/sbni/if_sbni_isa.c | 7 | ||||
-rw-r--r-- | sys/dev/sbni/if_sbni_pci.c | 17 | ||||
-rw-r--r-- | sys/dev/sbni/if_sbnivar.h | 2 |
4 files changed, 6 insertions, 25 deletions
diff --git a/sys/dev/sbni/if_sbni.c b/sys/dev/sbni/if_sbni.c index 4dbfae7777ef..ffbce54a56f2 100644 --- a/sys/dev/sbni/if_sbni.c +++ b/sys/dev/sbni/if_sbni.c @@ -212,7 +212,7 @@ sbni_probe(struct sbni_softc *sc) /* * Install interface into kernel networking data structures */ -int +void sbni_attach(struct sbni_softc *sc, int unit, struct sbni_flags flags) { if_t ifp; @@ -220,8 +220,6 @@ sbni_attach(struct sbni_softc *sc, int unit, struct sbni_flags flags) uint64_t baudrate; ifp = sc->ifp = if_alloc(IFT_ETHER); - if (ifp == NULL) - return (ENOMEM); sbni_outb(sc, CSR0, 0); set_initial_values(sc, flags); @@ -250,7 +248,6 @@ sbni_attach(struct sbni_softc *sc, int unit, struct sbni_flags flags) printf("auto\n"); else printf("%d (fixed)\n", sc->cur_rxl_index); - return (0); } void diff --git a/sys/dev/sbni/if_sbni_isa.c b/sys/dev/sbni/if_sbni_isa.c index 6f8c91a0b3bc..113ff3d954e4 100644 --- a/sys/dev/sbni/if_sbni_isa.c +++ b/sys/dev/sbni/if_sbni_isa.c @@ -136,12 +136,7 @@ sbni_attach_isa(device_t dev) *(u_int32_t*)&flags = device_get_flags(dev); - error = sbni_attach(sc, device_get_unit(dev) * 2, flags); - if (error) { - device_printf(dev, "cannot initialize driver\n"); - sbni_release_resources(sc); - return (error); - } + sbni_attach(sc, device_get_unit(dev) * 2, flags); if (sc->irq_res) { error = bus_setup_intr( diff --git a/sys/dev/sbni/if_sbni_pci.c b/sys/dev/sbni/if_sbni_pci.c index 60c70ec492f9..b1b0614613eb 100644 --- a/sys/dev/sbni/if_sbni_pci.c +++ b/sys/dev/sbni/if_sbni_pci.c @@ -131,20 +131,9 @@ sbni_pci_attach(device_t dev) memset(&flags, 0, sizeof(flags)); - error = sbni_attach(sc, device_get_unit(dev) * 2, flags); - if (error) { - device_printf(dev, "cannot initialize driver\n"); - goto attach_failed; - } - if (sc->slave_sc) { - error = sbni_attach(sc->slave_sc, device_get_unit(dev) * 2 + 1, - flags); - if (error) { - device_printf(dev, "cannot initialize slave\n"); - sbni_detach(sc); - goto attach_failed; - } - } + sbni_attach(sc, device_get_unit(dev) * 2, flags); + if (sc->slave_sc) + sbni_attach(sc->slave_sc, device_get_unit(dev) * 2 + 1, flags); if (sc->irq_res) { error = bus_setup_intr(dev, sc->irq_res, INTR_TYPE_NET | diff --git a/sys/dev/sbni/if_sbnivar.h b/sys/dev/sbni/if_sbnivar.h index 92678899a5d9..211d2bc56b0e 100644 --- a/sys/dev/sbni/if_sbnivar.h +++ b/sys/dev/sbni/if_sbnivar.h @@ -125,7 +125,7 @@ struct sbni_softc { void sbni_intr(void *); int sbni_probe(struct sbni_softc *); -int sbni_attach(struct sbni_softc *, int, struct sbni_flags); +void sbni_attach(struct sbni_softc *, int, struct sbni_flags); void sbni_detach(struct sbni_softc *); void sbni_release_resources(struct sbni_softc *); |