aboutsummaryrefslogtreecommitdiff
path: root/sys/dev/virtio/pci
diff options
context:
space:
mode:
Diffstat (limited to 'sys/dev/virtio/pci')
-rw-r--r--sys/dev/virtio/pci/virtio_pci.c14
-rw-r--r--sys/dev/virtio/pci/virtio_pci_legacy.c4
-rw-r--r--sys/dev/virtio/pci/virtio_pci_modern.c4
3 files changed, 7 insertions, 15 deletions
diff --git a/sys/dev/virtio/pci/virtio_pci.c b/sys/dev/virtio/pci/virtio_pci.c
index 4d93e94e59f2..b7b34b448f6e 100644
--- a/sys/dev/virtio/pci/virtio_pci.c
+++ b/sys/dev/virtio/pci/virtio_pci.c
@@ -168,7 +168,7 @@ vtpci_add_child(struct vtpci_common *cn)
dev = cn->vtpci_dev;
- child = device_add_child(dev, NULL, -1);
+ child = device_add_child(dev, NULL, DEVICE_UNIT_ANY);
if (child == NULL) {
device_printf(dev, "cannot create child device\n");
return (ENOMEM);
@@ -182,18 +182,14 @@ vtpci_add_child(struct vtpci_common *cn)
int
vtpci_delete_child(struct vtpci_common *cn)
{
- device_t dev, child;
+ device_t dev;
int error;
dev = cn->vtpci_dev;
- child = cn->vtpci_child_dev;
- if (child != NULL) {
- error = device_delete_child(dev, child);
- if (error)
- return (error);
- cn->vtpci_child_dev = NULL;
- }
+ error = bus_generic_detach(dev);
+ if (error)
+ return (error);
return (0);
}
diff --git a/sys/dev/virtio/pci/virtio_pci_legacy.c b/sys/dev/virtio/pci/virtio_pci_legacy.c
index 238434c350fb..18dbb00e0d8c 100644
--- a/sys/dev/virtio/pci/virtio_pci_legacy.c
+++ b/sys/dev/virtio/pci/virtio_pci_legacy.c
@@ -190,7 +190,6 @@ DRIVER_MODULE(virtio_pci_legacy, pci, vtpci_legacy_driver, 0, 0);
static int
vtpci_legacy_probe(device_t dev)
{
- char desc[64];
const char *name;
if (pci_get_vendor(dev) != VIRTIO_PCI_VENDORID)
@@ -207,8 +206,7 @@ vtpci_legacy_probe(device_t dev)
if (name == NULL)
name = "Unknown";
- snprintf(desc, sizeof(desc), "VirtIO PCI (legacy) %s adapter", name);
- device_set_desc_copy(dev, desc);
+ device_set_descf(dev, "VirtIO PCI (legacy) %s adapter", name);
/* Prefer transitional modern VirtIO PCI. */
return (BUS_PROBE_LOW_PRIORITY);
diff --git a/sys/dev/virtio/pci/virtio_pci_modern.c b/sys/dev/virtio/pci/virtio_pci_modern.c
index 8f9b1f21aeab..eb1d5a1e6989 100644
--- a/sys/dev/virtio/pci/virtio_pci_modern.c
+++ b/sys/dev/virtio/pci/virtio_pci_modern.c
@@ -244,7 +244,6 @@ DRIVER_MODULE(virtio_pci_modern, pci, vtpci_modern_driver, 0, 0);
static int
vtpci_modern_probe(device_t dev)
{
- char desc[64];
const char *name;
uint16_t devid;
@@ -269,8 +268,7 @@ vtpci_modern_probe(device_t dev)
if (name == NULL)
name = "Unknown";
- snprintf(desc, sizeof(desc), "VirtIO PCI (modern) %s adapter", name);
- device_set_desc_copy(dev, desc);
+ device_set_descf(dev, "VirtIO PCI (modern) %s adapter", name);
return (BUS_PROBE_DEFAULT);
}