aboutsummaryrefslogtreecommitdiff
path: root/libexec/rtld-elf
Commit message (Collapse)AuthorAgeFilesLines
* packages: Remove the tests-dev packageLexi Winter2025-09-181-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We don't want a tests-dev package, because this means set-devel depends on tests-dev, which transitively depends on tests, which means you can't install set-devel without also getting tests. The only real "dev" files in tests-dev are from ATF (libprivateatf), so move that to its own package and add a dependency from tests. Also move Kyua to its own package, since this might be useful for running tests even when the user doesn't want the whole set of base tests installed. Add a dependency from -tests to both -atf and -kyua, and a dependency on -set-base, since the tests won't work without the full base system installed. The remaining "dev" files in tests are actually test artifacts, not real development libraries. Add a new NO_DEV_PACKAGE option to bsd.lib.mk, which causes dev files to be installed in the base package instead of creating a -dev package, and set this option for everything that installs test libraries. While here, add a slightly more informative description for the tests package. MFC after: 3 seconds Reviewed by: bapt, emaste Differential Revision: https://reviews.freebsd.org/D52597
* rtld: Add UTRACE_LOAD_OBJECT traces for rtld and the main binaryJohn Baldwin2025-08-221-0/+4
| | | | | | | | | | | These two objects are loaded by the kernel not rtld, but adding these two traces means that UTRACE_LOAD_OBJECT traces now describe the mappings for all executables and DSOs in a process' address space. Reviewed by: kib Obtained from: CheriBSD Sponsored by: AFRL, DARPA Differential Revision: https://reviews.freebsd.org/D52034
* rtld: Compute obj->maxsize for obj_rtldJohn Baldwin2025-08-221-0/+10
| | | | | | | | | Compute this while parsing the program headers in parse_rtld_phdr(). Reviewed by: kib Obtained from: CheriBSD Sponsored by: AFRL, DARPA Differential Revision: https://reviews.freebsd.org/D52033
* rtld-elf: Fix VDSO Obj_Entry mapsize and report in utrace(2)Jessica Clarke2025-08-151-2/+3
| | | | | | | | | | Subtracing addr is only appropriate for position-dependent objects, where vaddrbase would also be the same value. For position-independent objects, like the VDSO (which we already assume due to setting vaddrbase to 0), the segments start at 0, not addr. Reviewed by: kib Differential Revision: https://reviews.freebsd.org/D51924
* rtld: require MAP_GUARD supportBrooks Davis2025-08-111-5/+1
| | | | | | | | MAP_GUARD was added prior to 12.0. We don't support such old kernels in userspace so drop the support. Reviewed by: kib Differential Revision: https://reviews.freebsd.org/D50731
* amd64: assume the kernel supports RDFSBASE and RDGSBASEBrooks Davis2025-08-081-2/+1
| | | | | | | | | | | There is no need to support pre-12.0 (and thus pre-ino64) kernels in a 15.x libc. Continue to check if the CPU supports these features before using them and fall back as required. Reviewed by: kib Differential Revision: https://reviews.freebsd.org/D50732
* syscalls: normalize _exit(2) declerationsBrooks Davis2025-08-081-3/+3
| | | | | | | | | | | | | | | | | | | exit(3) is implemented by the runtime and performs a number of shutdown actions before ultimately calling _exit(2) to terminate the program. We historically named the syscall table entry `exit` rather than `_exit`, but this requires special handling in libc/libsys to cause the `_exit` symbol to exist while implementing `exit` in libc. Declare the syscall as `_exit` and flow that through the system. Because syscall(SYS_exit, code) is fairly widely used, allow a configured extra line in syscall.h to define SYS_exit to SYS__exit. I've found no external uses of __sys_exit() so I've not bothered to create a compatability version of this private symbol. Reviewed by: imp, kib, emaste Differential Revision: https://reviews.freebsd.org/D51672
* rtld: fix dependencies for rtld-libcBrooks Davis2025-08-082-1/+9
| | | | | | | | | | | | | | | | | Previously we (appropriately, but incorrectly) attempted to depend on LIBC_NOSSP_PIC and LIBSYS_PIC for rtld_libc.a. Unfortunately, variables in dependency lists are expanded at parse time and those variables are defined in bsd.libnames.mk which *must* be included by bsd.{lib,prog}.mk. As such, they were undefined and thus expanded to the empty string resulting in no dependency with predictable and highly confusing results. Move the declaration of these dependencies to after the include of bsd.prog.mk and add comments on both side in hopes of keeping any future dependencies in sync. Reviewed by: kib Differential Revision: https://reviews.freebsd.org/D51790
* rtld-elf: Don't include duplicate semicolon in Obj_EntryJessica Clarke2025-08-071-1/+1
| | | | | | | | | | | | | | | | | | | | | | | MD_OBJ_ENTRY is a list of members, possibly empty, to include in Obj_Entry. By including the semicolon here, in the case that it's empty, we end up with a duplicate semicolon. In the case that it's not empty, whether there's a duplicate depends on each architecture's definition, but they all in fact put a semicolon after every member, so there is also a duplicate semicolon there. This is invalid C syntax, although both GCC and Clang accept it, treating it only as a pedantic warning, but there is no need for us to rely on that, and downstream it masked a missing semicolon for an added field, but only on architectures where MD_OBJ_ENTRY is empty, leading to conditional compilation failure for something that should have been detected as an unconditional error. Note that PCPU_MD_FIELDS, which this is based on, follows a different style. There, every architecture defines at least one member, and there is a semicolon after PCPU_MD_FIELDS in sys/sys/pcpu.h, but every architecture makes sure to not put a semicolon after the final member in its definition of the macro. This is not a pattern we can adhere to here though given not all architectures add members. Fixes: 06db20ffeca9 ("rtld: Add MD_OBJ_ENTRY to extend Struct_Obj_Entry")
* rtld: do not relocate tlsinit address twiceKonstantin Belousov2025-07-211-1/+1
| | | | | | | | | | | | | | | The addend for PT_TLS p_vaddr value should be obj' relocbase and not mapbase. It does not matter for dso which is linked at the address zero, but for executables in direct-exec mode with non-zero link address mapbase is already at the link base. Then, adding mapbase to phtls->p_vaddr adds twice as much relocbase offset as needed. PR: 288334 Reported by: Jordan Gordeev <jgopensource@proton.me> Reviewed by: jrtc27 Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D51448
* rtld-elf: Delete unused RELOC_ALIGNED_P copiesJessica Clarke2025-07-112-14/+0
| | | | | | This was copied from arm to aarch64 to riscv, but only arm uses it. MFC after: 1 week
* rtld-elf: Track allocated TCBs internally and use for distribute_static_tlsJessica Clarke2025-07-101-16/+87
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently rtld delegates to libc or libthr to initialise the TCBs for all existing threads when dlopen is called for a library that is using static TLS. This creates an odd split where rtld manages all of TLS for dynamically-linked executables except for this specific case, and is unnecessarily complex, including having to reason about the locking due to dropping the bind lock so libthr can take the thread list lock without deadlocking if any of the code run whilst that lock is held ends up calling back into rtld (such as for lazy PLT resolution). The only real reason we call out into libc / libthr is that we don't have a list of threads in rtld and that's how we find the currently used TCBs to initialise (and at the same time do the copy in the callee rather than adding overhead with some kind of callback that provides the TCB to rtld. If we instead keep a list of allocated TCBs in rtld itself then we no longer need to do this, and can just copy the data in rtld. How these TCBs are mapped to threads is irrelevant, rtld can just treat all TCBs equally and ensure that each TCB's static TLS data block remains in sync with the current set of loaded modules, just as how _rtld_allocate_tls creates a fresh TCB and associated data without any embedded threading model assumptions. As an implementation detail, to avoid a separate allocation for the list entry and having to find that allocation from the TCB to remove and free it on deallocation, we allocate a fake TLS offset for it and embed the list entry there in each TLS block. This will also make it easier to add a new TLS ABI downstream in CheriBSD, especially in the presence of library compartmentalisation. Reviewed by: kib Differential Revision: https://reviews.freebsd.org/D50920
* rtld-elf: Extract part of allocate_tls_offset into allocate_tls_offset_commonJessica Clarke2025-07-101-21/+33
| | | | | | | | This will be used to allocate additional space for a TAILQ_ENTRY by rtld at a known offset from the TCB, as if it were TLS data. Reviewed by: kib Differential Revision: https://reviews.freebsd.org/D51068
* rtld-elf: Add Add AT_HWCAP3 and AT_HWCAP4Andrew Turner2025-06-241-0/+4
| | | | | | | | Add the AT_HWCAP3 and AT_HWCAP4 format strings to auxfmt. Reviewed by: brooks, kib Sponsored by: Arm Ltd Differential Revision: https://reviews.freebsd.org/D51007
* rtld-elf: Pass TCB to allocate_module_tls to avoid re-gettingJessica Clarke2025-05-292-5/+5
| | | | | | | | | | The only caller already has the current TCB to hand, so just pass it down rather than get it again. This also makes it clear in the caller that it depends on the (current) TCB, rather than being storage that could be assigned to any thread (concurrency issues aside). Reviewed by: kib Differential Revision: https://reviews.freebsd.org/D50594
* rtld-elf: Pass struct tcb * around rather than struct dtv **Jessica Clarke2025-05-2910-46/+19
| | | | | | | | | | | | | | | | | | | | When this code was first written we didn't have even a struct tcb, so to make it MI a pointer to the DTV pointer in the TCB was passed around. Now that we have a struct tcb we can simplify the code by instead passing around a pointer to that, and the MI code can access the tcb_dtv member wherever it happens to be in the layout. This reduces boilerplate in all the various callers of tls_get_addr_common/slow and makes it clearer that tls_get_addr_common/slow are operating on the TCB, rather than obfuscating it slightly through the double pointer. Whilst here, clarify the comments in aarch64's TLSDESC dynamic resolver, which were using tp without clarifying what this was for (previously a pointer to the DTV pointer, now a pointer to the TCB, which happen to be the same thing for Variant I TLS, and in the case of AArch64 are what TPIDR_EL0 point to directly, with no offset/bias). Reviewed by: kib Differential Revision: https://reviews.freebsd.org/D50591
* Revert "rtld: fix allocate_module_tls() variant I fallback to static allocation"Jessica Clarke2025-05-281-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This was applying a NetBSD fix to FreeBSD. However, the original code was correct for FreeBSD. NetBSD's obj->tlsoffset is relative to the end of the TCB, not the TCB itself, whilst ours is relative to the TCB[1] itself. For example, our allocate_tls uses (char *)tcb + obj->tlsoffset for the memcpy and memset calls. Without this reverted, for dynamically loaded shared objects, Initial Exec accesses to TLS variables on variant I architectures (non-x86) use the correct address, whilst General Dynamic and dlsym(3) use the incorrect address (TLS_TCB_SIZE past the start). Note that, on arm64, LLVM only supports TLSDESC (including LLD) and TLSDESC will use the static resolver if the variable ends up allocated to the static TLS block, even in the presence of dlopen(3), so only dlsym(3) shows the discrepancy there. Whilst here, add a comment to explain this difference to try and avoid the same mistake being made in future. [1] In the case of variant II, it's the amount to subtract, so still positive This reverts commit e9a38ed2fa61fd264a80f24ceb35f39b0ac6463d. Reviewed by: kib (prior version) Fixes: e9a38ed2fa61 ("rtld: fix allocate_module_tls() variant I fallback to static allocation") MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D50565
* rtld-elf/riscv: Don't allocate static TLS for dynamic TLS relocationsJessica Clarke2025-05-281-17/+0
| | | | | | | | | | | Provided you don't run out of extra static TLS space this should work, but it's wholly unnecessary and not how things are supposed to be done. Only static TLS relocations should allocate static TLS. Reviewed by: kib Fixes: 4b1859c0e943 ("Add support for RISC-V architecture.") MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D50563
* amd64: switch to amd64_set_tlsbase to set tls baseKonstantin Belousov2025-05-281-2/+4
| | | | | | | | | Reported and tested: Alex S <iwtcex@gmail.com> Tested by: pho Reviewed by: olce Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D50482
* rtld: get syscall implementations from libsysBrooks Davis2025-05-231-11/+19
| | | | | | | | | | | | When I added libsys I failed to update rtld's reuse of object files from libc to use ones from libsys instead. This would have turned up as a broken system in d7847a8d35143, but SHARED_CFLAGS is not being applied to assembly files. PR: 286975 Reviewed by: jrtc27, jhb Sponsored by: DARPA, AFRL Differential Revision: https://reviews.freebsd.org/D50475
* rtld: remove stray tabsKonstantin Belousov2025-05-081-2/+2
| | | | | Sponsored by: The FreeBSD Foundation MFC after: 1 week
* rtld-elf: Use size_t rather than uintptr_t for an indexJessica Clarke2025-05-071-1/+1
| | | | | | | | | This was previously an Elf_Addr and was turned into a uintptr_t when really it should have been made a size_t. Even on CHERI both actually work in this case, but it's better style (and more consistent with elsewhere in the file) to use size_t instead. Fixes: 4642b638a522 ("rtld-elf: Consistently use uintptr_t for TLS implementation")
* tls: Introduce struct dtv and struct dtv_slotJessica Clarke2025-05-079-62/+74
| | | | | | | | | | | | | | Rather than treating the DTV as a raw array of uintptr_t, use proper struct types and gain the benefit of having different types for different members. In particular, the module slots now have real pointer types so less casting is generally needed. Note that, whilst struct dtv_slot may seem a little unnecessary, this will help downstream in CheriBSD where we wish to be able to easily alter the layout of a module's slot, which this helps abstract. Reviewed by: kib Differential Revision: https://reviews.freebsd.org/D50231
* rtld-elf: Use clear pointer provenance when updating DTV pointerJessica Clarke2025-05-071-2/+2
| | | | | | | | | | | | On traditional architectures where uintptr_t is just a plain integer, there is no provenance from the order of operations. However, on CHERI there is even for uintptr_t, and in future this code will use actual pointer types anyway, where the provenance does technically matter even for non-CHERI. Commute and associate the operands appropriately to ensure the provenance is for the new allocation, not the old one. Reviewed by: kib Differential Revision: https://reviews.freebsd.org/D50230
* rtld-elf: Use struct tcb * rather than uintptr_t ** for the tcbJessica Clarke2025-05-071-11/+12
| | | | | | | | This lets us access via named struct members rather than magic hard-coded indices. Reviewed by: kib Differential Revision: https://reviews.freebsd.org/D50229
* rtld-elf: Use variables more consistent with Variant I for Variant II TLSJessica Clarke2025-05-071-22/+21
| | | | | | | | | | | | | | | | | | | | Firstly, the second argument to allocate_tls is the old TCB (versus oldtls, which has less of a clear meaning), so rename it to oldtcb like Variant I. Secondly, segbase and oldsegbase are oriented towards what ends up in the segment registers, but that's not the main concern here, and those don't convey what they actually point to. Instead, rename segbase to tcb and change it to a uintptr_t **, and remove oldsegbase as it's always equal to oldtcb, again both matching Variant I. Thirdly, rename tls to tls_block, again both matching Variant I. Finally, similarly rename tls to tcb in free_tls, and oldtls to oldtcb in the common _rtld_allocate_tls. Reviewed by: kib Differential Revision: https://reviews.freebsd.org/D50232
* rtld-elf: Consistently use uintptr_t for TLS implementationJessica Clarke2025-05-071-47/+47
| | | | | | | | | | | | | | | | | | | | | | | | Elf_Addr is the format of addresses in the ELF file with the current ABI's default class. This is normally the same as the format of an address at run time, though technically exceptions do exist outside of FreeBSD's currently-supported architectures (for example, IA-64's LP64 supports both ELFCLASS32 and ELFCLASS64 file formats; LP64 vs ILP32 is an orthogonal EF_IA_64_ABI64 flag). On traditional architectures, including all currently-supported FreeBSD architectures, addresses and pointers are synonymous, but on CHERI they are not, as pointers are capabilities that contain metadata alongside the address. In the cases here, the quantities are run-time pointers, not addresses (and definitely not ELF file addresses), so we should use pointer-ish types. Note that we already use uintptr_t in struct tcb (both Variant I and Variant II) but still use Elf_Addr in various places here (including different argument types for tls_get_addr_slow and tls_get_addr_common). Also use char * for addr rather than even uintptr_t, since most of the time we want it to be an actual pointer. Reviewed by: kib Differential Revision: https://reviews.freebsd.org/D50226
* rtld-elf: Push TLS_DTV_OFFSET into tls_get_addr_common's argumentsJessica Clarke2025-05-063-12/+6
| | | | | | | | | | Rather than calling tls_get_addr_common with a biased ti_offset and un-biasing the return value, we can instead un-bias the offset given in the first place and not need to adjust the return value. This is in fact how the MIPS implementation worked, and makes this call tail-recursive. Reviewed by: kib Differential Revision: https://reviews.freebsd.org/D50187
* rtld-elf: Fix executable's TLS module index for direct execJessica Clarke2025-05-063-6/+10
| | | | | | | | | | | | | | | | | | | | | | | | | For direct exec mode we reuse map_object, but tls_max_index is initialised to 1. As a result, the executable ends up being assigned module 2 (and the generation is pointlessly incremented, unlike in digest_phdr for the normal case). For most architectures this is harmless, since TLS linker relaxation will optimise General Dynamic accesses to Initial Exec or Local Exec for executables, but on RISC-V this relaxation does not exist, yet the linker will initialise the tls_index in the GOT with module 1, and at run time the call to __tls_get_addr will fail with: ld-elf.so.1: Can't find module with TLS index 1 Fix this by making map_object use 1 for obj->tlsindex when it's loading the main executable, and don't bother to increment tls_dtv_generation either, matching digest_phdr (though that one is harmless). (Note this also applies to MIPS on stable/13) Reviewed by: kib Fixes: 0fc65b0ab82c ("Make ld-elf.so.1 directly executable.") MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D50186
* rtld-elf: Fix UB for direct exec with no extra rtld argumentsJessica Clarke2025-05-061-2/+7
| | | | | | | | | | | | | | | | | | | | | | | If no extra rtld arguments are provided, rtld_argc will be 1 (for argv[0] and so we are shifting the entire memory range down by a single pointer. However, unlike argv and envp, auxp's entries are two pointers in size, not one, and so in this case the source and destination overlap, meaning simple assignment is UB (C99 6.5.16.1p3). On many architectures this ends up being harmless as the compiler will emit double machine word loads and stores, or if it splits them it may still schedule them such that it works in this case, but our RISC-V baseline does not include such instructions and LLVM ends up picking a schedule that copies the second word before the first word, thereby replacing the first word with a copy of the second word. This results in direct exec mode segfaulting on RISC-V when given no arguments. Fix this by using a temporary in the source and let the compiler safely elide its use. Reviewed by: kib Fixes: 0fc65b0ab82c ("Make ld-elf.so.1 directly executable.") MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D50185
* rtld-elf: Fix dl_iterate_phdr's dlpi_tls_data for PowerPC and RISC-VJessica Clarke2025-05-061-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | The implementation of dl_iterate_phdr abuses tls_get_addr_slow to get to the start of the TLS block, inlining the implementation of __tls_get_addr as if the tls_index's ti_offset were 0 (historically it called __tls_get_addr itself but changed due to locking issues). For most architectures, tls_index's ti_offset (relocated by DTPOFF/DTPREL for GOT entries) is just the offset within that module's TLS block. However, for PowerPC and RISC-V, which have a non-zero TLS_DTV_OFFSET and thus are designed assuming DTV entries are biased by that value, ti_offset normally has TLS_DTV_OFFSET pre-subtracted, but it's __tls_get_addr's responsibility to compensate for that. By using an offset of zero here, tls_get_addr_slow will return a pointer to the start of the TLS block itself, so by adding TLS_DTV_OFFSET we will point TLS_DTV_OFFSET past the module's TLS block. Fix this by removing the extra bias (the alternative would be to pass -TLS_DTV_OFFSET and keep the addition, which would more closely follow what __tls_get_addr does, but this is more direct). (Note this also applies to MIPS on stable/13) Reviewed by: kib Fixes: d36d68161517 ("rtld dl_iterate_phdr(): dlpi_tls_data is wrong") MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D50184
* rtld-elf: Fix dlsym(3) for TLS symbols on PowerPC and RISC-VJessica Clarke2025-05-061-1/+1
| | | | | | | | | | | | | | | The implementation here is meant to mirror what a GOT entry for the given symbol would use for ti_offset. However, on PowerPC and RISC-V, TLS_DTV_OFFSET is non-zero, and so the GOT entries are normally biased by this, but we fail to do so here. As a result we end up getting a pointer TLS_DTV_OFFSET past where the variable actually is. (Note this also applies to MIPS on stable/13) Reviewed by: kib Fixes: 5ceeeba90c6c ("Import DragonFly BSD commit") MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D50183
* rtld: add support for -z initfirstKonstantin Belousov2025-05-062-31/+97
| | | | | | | | | | | | | | | Internally, initfirst objects and their needed objects are put on the dedicated initlist, which is prepended to the current regular initlist at the last moment. This results in the move of the needed objects into the beginning of the initlist, which is required for the proper initialization of the dependencies. It seems that glibc moves only the initfirst object, which makes its constructors depend on not yet initialized dsos. Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D50132
* rtld: styleKonstantin Belousov2025-05-061-2/+2
|
* rtld: do not call into ifunc resolvers with the bind lock write-lockedKonstantin Belousov2025-05-021-2/+8
| | | | | | | | | | If filter needs to be loader, we restart after the lock upgrade. But possible binds in the resolver itself would try to recurse on the lock, which can be only done for the read locks. PR: 286502 Sponsored by: The FreeBSD Foundation MFC after: 1 week
* rtld: add lockstate_wlocked()Konstantin Belousov2025-05-022-0/+7
| | | | | | | querying the lockstate for write-locked state. Sponsored by: The FreeBSD Foundation MFC after: 1 week
* rtld: some style in rtld_lock.cKonstantin Belousov2025-05-021-2/+2
|
* rtld: apply some style to resolve_object_ifunc()Konstantin Belousov2025-05-021-4/+4
| | | | Sponsored by: The FreeBSD Foundation
* rtld: apply some style to dlopen_object()Konstantin Belousov2025-05-021-9/+8
| | | | Sponsored by: The FreeBSD Foundation
* rtld: symbolic and deepbind are equivalent for the refobjKonstantin Belousov2025-04-231-2/+3
| | | | | | Reported by: avg Sponsored by: The FreeBSD Foundation MFC after: 1 week
* rtld: fix indent in dlopen_object()Konstantin Belousov2025-04-231-10/+8
| | | | Sponsored by: The FreeBSD Foundation
* rtld: fix several style(9) bugsKonstantin Belousov2025-03-181-21/+27
| | | | Sponsored by: The FreeBSD Foundation
* libc/gen: split user-visible opendir()-like functions into separate source filesKonstantin Belousov2025-02-251-1/+1
| | | | | | | | | | | | | | | | | | This allows, for instance, to interpose opendir() with an implementation that calls into fdopendir(), without causing multiple symbol definitions when libc is linked in statically. This is aligned with the quality of implementation principle that single object file from a static library should not provide more than one app-visible symbol. [The copyright for fopendir() was copied, it might be refined by the author] Reviewed by: brooks Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D49089
* libsys: Don't create or expose __realpathatBrooks Davis2025-02-191-1/+1
| | | | | | | | | | | | | | | | Previously, __realpathat was in libc and libsys (as is currently standard), but not exported from libc which meant the stub in libc was not filtered and thus libc's copy of the syscall was used. This broke an upcoming change to CheriBSD limiting syscalls to libsys. The realpath(3) implementation now uses __sys___realpathat so there are no consumers of __realpathat. Switch it to PSEUDO (only _foo and __sys_foo symbols) and remove __realpathat from Symbol.map. This is a corrected version of 58d43a3cd72a4a85ab8489313672c7eab367495e. Reviewed by: kib Differential Revision: https://reviews.freebsd.org/D49049
* rtld: clear any holes in the struct utrace_rtld passed to kernel loggerKonstantin Belousov2025-02-051-2/+2
| | | | | | | | | | | | This should avoid an (almost) false positive from Valgrind, by filling the padding on LP64. PR: 284563 Reported by: Paul Floyd <pjfloyd@wanadoo.fr> Reviewed by: emaste Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D48854
* rtld-elf/i386/reloc.c: apply clang-formatKonstantin Belousov2025-01-211-181/+186
| | | | | | Discussed with: emaste, imp Sponsored by: The FreeBSD Foundation Differential revision: https://reviews.freebsd.org/D48509
* rtld-elf/amd64/reloc.c: apply clang-formatKonstantin Belousov2025-01-211-167/+180
| | | | | | Discussed with: emaste, imp Sponsored by: The FreeBSD Foundation Differential revision: https://reviews.freebsd.org/D48509
* rtld-elf/{amd64,i386}/reloc.c: remove unneeded #ifdef dbgKonstantin Belousov2025-01-212-4/+0
| | | | | | | Discussed with: emaste, imp Sponsored by: The FreeBSD Foundation MFC after: 3 days Differential revision: https://reviews.freebsd.org/D48509
* rtld-elf/map_object.c: apply clang-formatKonstantin Belousov2025-01-211-314/+339
| | | | | | Discussed with: emaste, imp Sponsored by: The FreeBSD Foundation Differential revision: https://reviews.freebsd.org/D48509
* rtld obj_remap_relro(): unindent the loop bodyKonstantin Belousov2025-01-211-12/+10
| | | | | | Discussed with: emaste, imp Sponsored by: The FreeBSD Foundation Differential revision: https://reviews.freebsd.org/D48509
generated by cgit v1.2.3 (git 2.25.1) at 2025-11-03 03:36:08 +0000