aboutsummaryrefslogtreecommitdiff
path: root/sys/dev/bxe/bxe.c
Commit message (Collapse)AuthorAgeFilesLines
* ifnet: Remove if_getamcount()Mark Johnston2024-09-041-1/+1
| | | | | | | | | | | | | | All uses of this function were incorrect. if_amcount is a reference count which tracks the number of times the network stack internally set IFF_ALLMULTI. (if_pcount is the corresponding counter for IFF_PROMISC.) Remove if_getamcount() and fix up callers to get the number of assigned multicast addresses instead, since that's what they actually want. Sponsored by: Klara, Inc. Reviewed by: zlei, glebius MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D46523
* net: Remove unneeded NULL check for the allocated ifnetZhenlei Huang2024-06-281-13/+3
| | | | | | | | | | | Change 4787572d0580 made if_alloc_domain() never fail, then also do the wrappers if_alloc(), if_alloc_dev(), and if_gethandle(). No functional change intended. Reviewed by: kp, imp, glebius, stevek MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D45740
* bxe: Use device_set_descf()Mark Johnston2024-06-161-10/+1
| | | | | | No functional change intended. MFC after: 1 week
* bxe(4): Fix two typos in a kernel messagesGordon Bergling2024-02-271-2/+2
| | | | | | - s/successfull/successful/ MFC after: 3 days
* IfAPI: Retire if_etherbpfmtap() and if_bpfmtap()Justin Hibbits2023-08-251-2/+2
| | | | | | | | | | | | Summary: These came in the original DrvAPI commits in 2014, and are obsoleted by bpf_mtap_if() and ether_bpf_mtap_if(). The `_if` suffix, rather than prefix, conveys that it's operating on the bpf of the interface, instead than the interface itself. Reviewed by: glebius Sponsored by: Juniper Networks, Inc. Differential Revision: https://reviews.freebsd.org/D41146
* sys: Remove $FreeBSD$: one-line .c patternWarner Losh2023-08-161-2/+0
| | | | Remove /^[\s*]*__FBSDID\("\$FreeBSD\$"\);?\s*\n/
* bxe: prefer C99 bool to boolean_tEd Maste2023-05-011-13/+13
| | | | Differential Revision: https://reviews.freebsd.org/D20853
* bxe(4): Use CTLFLAG_RDTUN flag definitionZhenlei Huang2023-04-121-2/+2
| | | | | | | | | | | sysctl variables rx_budget and max_aggregation_size are read-only loader tunable. Mark them with CTLFLAG_RD flag. No functional change intended. Reviewed by: hselasky, erj MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D39466
* DrvAPI: Trivial mechanical conversions for various driversJustin Hibbits2022-12-211-10/+10
| | | | | | | | | | | | | | | | | Mechanically convert the following drivers, with trivial changes: * ipw(4) * igc(4) * enetc(4) * malo(4) * nfe(4) * bxe(4) * awg(4) * otus(4) * rtwn(4) * bnxt(4) * ath(4) Sponsored by: Juniper Networks, Inc.
* bxe(4): Fix a typo in a source code commentGordon Bergling2022-11-011-1/+1
| | | | | | - s/interrutps/interrupts/ MFC after: 3 days
* bxe(4): Grammar fix for a source code commentGordon Bergling2022-09-041-1/+1
| | | | | | - s/that that/that the/ MFC after: 3 days
* bxe: Remove unused devclass argument to DRIVER_MODULE.John Baldwin2022-05-061-7/+1
|
* bxe: Quiet set but not used warnings.John Baldwin2022-04-061-6/+5
| | | | | | Comment out other references to more_tx since the only use is commented out. Remove unused is_parity variable.
* bxe(4): Fix a typo in an error messageGordon Bergling2022-04-021-1/+1
| | | | | | - s/intergers/integers/ MFC after: 3 days
* bxe: plug some of set-but-not-used varsMateusz Guzik2021-12-101-12/+1
| | | | Sponsored by: Rubicon Communications, LLC ("Netgate")
* ifnet: garbage collect drbr_*_drv().Gleb Smirnoff2021-11-231-1/+1
| | | | They were left in 62d76917b8678 but after years proved not to be useful.
* bxe(4): Mark sysctls and callout MP-safe.Alexander Motin2021-09-031-5/+5
| | | | MFC after: 1 month
* Fix a typo that was introduced while fixing a typoGordon Bergling2021-08-141-1/+1
| | | | | | - s/enrtry/entry/ MFC after: 5 days
* Fix a common typo in a commentGordon Bergling2021-08-141-1/+1
| | | | | | - s/enrty/entry/ MFC after: 5 days
* Remove newline from bxe description, it's not done elsewhere.Warner Losh2020-11-091-1/+1
| | | | Notes: svn path=/head/; revision=367514
* remove extraneous double ;s in sys/Ed Maste2020-03-301-1/+1
| | | | Notes: svn path=/head/; revision=359441
* Finish removing support from old versionsWarner Losh2020-03-011-84/+1
| | | | | | | | | | Eliminate code for old versions, inline pci_find_cap instead of relying on compat ifdef. This commit should have been combined with r358488 before pushing it in. Notes: svn path=/head/; revision=358491
* Remove FreeBSD 7-10 support from bxe driver.Warner Losh2020-03-011-10/+10
| | | | | | | | Use new PCIER and PCIEM names in the driver rather than relying on old, compat shims. Notes: svn path=/head/; revision=358488
* Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (17 of many)Pawel Biernacki2020-02-261-18/+16
| | | | | | | | | | | | | | | | | | | r357614 added CTLFLAG_NEEDGIANT to make it easier to find nodes that are still not MPSAFE (or already are but aren’t properly marked). Use it in preparation for a general review of all nodes. This is non-functional change that adds annotations to SYSCTL_NODE and SYSCTL_PROC nodes using one of the soon-to-be-required flags. Mark all obvious cases as MPSAFE. All entries that haven't been marked as MPSAFE before are by default marked as NEEDGIANT Approved by: kib (mentor, blanket) Commented by: kib, gallatin, melifaro Differential Revision: https://reviews.freebsd.org/D23718 Notes: svn path=/head/; revision=358333
* Use NET_TASK_INIT() and NET_GROUPTASK_INIT() for drivers that processGleb Smirnoff2020-02-111-1/+1
| | | | | | | | | | incoming packets in taskqueue context. Reviewed by: hselasky Differential Revision: https://reviews.freebsd.org/D23518 Notes: svn path=/head/; revision=357772
* Convert to if_foreach_llmaddr() KPI.Gleb Smirnoff2019-10-211-68/+57
| | | | Notes: svn path=/head/; revision=353813
* Split out a more generic debugnet(4) from netdump(4)Conrad Meyer2019-10-171-10/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Debugnet is a simplistic and specialized panic- or debug-time reliable datagram transport. It can drive a single connection at a time and is currently unidirectional (debug/panic machine transmit to remote server only). It is mostly a verbatim code lift from netdump(4). Netdump(4) remains the only consumer (until the rest of this patch series lands). The INET-specific logic has been extracted somewhat more thoroughly than previously in netdump(4), into debugnet_inet.c. UDP-layer logic and up, as much as possible as is protocol-independent, remains in debugnet.c. The separation is not perfect and future improvement is welcome. Supporting INET6 is a long-term goal. Much of the diff is "gratuitous" renaming from 'netdump_' or 'nd_' to 'debugnet_' or 'dn_' -- sorry. I thought keeping the netdump name on the generic module would be more confusing than the refactoring. The only functional change here is the mbuf allocation / tracking. Instead of initiating solely on netdump-configured interface(s) at dumpon(8) configuration time, we watch for any debugnet-enabled NIC for link activation and query it for mbuf parameters at that time. If they exceed the existing high-water mark allocation, we re-allocate and track the new high-water mark. Otherwise, we leave the pre-panic mbuf allocation alone. In a future patch in this series, this will allow initiating netdump from panic ddb(4) without pre-panic configuration. No other functional change intended. Reviewed by: markj (earlier version) Some discussion with: emaste, jhb Objection from: marius Differential Revision: https://reviews.freebsd.org/D21421 Notes: svn path=/head/; revision=353685
* Add support for Error RecoveryDavid C Somayajulu2018-10-151-24/+347
| | | | | | | | | Submitted by:Vaishali.Kulkarni@cavium.com Approved by:re(kib) MFC after:5 days Notes: svn path=/head/; revision=339366
* Fixed isses:David C Somayajulu2018-09-171-8/+10
| | | | | | | | | | | State check before enqueuing transmit task in bxe_link_attn() routine. State check before invoking bxe_nic_unload in bxe_shutdown(). Submitted by:Vaishali.Kulkarni@cavium.com Approved by:re(gjb) Notes: svn path=/head/; revision=338734
* Fixes for the following issues:David C Somayajulu2018-07-171-14/+30
| | | | | | | | | | | | | 1. Fix taskqueues drain/free to fix panic seen when interface is being bought down and in parallel asynchronous link events happening. 2. Fix bxe_ifmedia_status() Submitted by:Vaishali.Kulkarni@cavium.com and Anand.Khoje@cavium.com MFC after:5 days Notes: svn path=/head/; revision=336438
* Fix build of bxe with base gcc on i386Dimitry Andric2018-06-111-4/+4
| | | | | | | | | | | | | | | Casting from rman_res_t to a pointer results in "cast to pointer from integer of different size" warnings with base gcc on i386, so print these without casting. The kva field of struct bxe_bar is of type vm_offset_t, which can be 32 or 64 bit, so cast it to uintmax_t before printing. Reviewed by: markj MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D15733 Notes: svn path=/head/; revision=334948
* ifnet: Replace if_addr_lock rwlock with epoch + mutexMatt Macy2018-05-181-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Run on LLNW canaries and tested by pho@ gallatin: Using a 14-core, 28-HTT single socket E5-2697 v3 with a 40GbE MLX5 based ConnectX 4-LX NIC, I see an almost 12% improvement in received packet rate, and a larger improvement in bytes delivered all the way to userspace. When the host receiving 64 streams of netperf -H $DUT -t UDP_STREAM -- -m 1, I see, using nstat -I mce0 1 before the patch: InMpps OMpps InGbs OGbs err TCP Est %CPU syscalls csw irq GBfree 4.98 0.00 4.42 0.00 4235592 33 83.80 4720653 2149771 1235 247.32 4.73 0.00 4.20 0.00 4025260 33 82.99 4724900 2139833 1204 247.32 4.72 0.00 4.20 0.00 4035252 33 82.14 4719162 2132023 1264 247.32 4.71 0.00 4.21 0.00 4073206 33 83.68 4744973 2123317 1347 247.32 4.72 0.00 4.21 0.00 4061118 33 80.82 4713615 2188091 1490 247.32 4.72 0.00 4.21 0.00 4051675 33 85.29 4727399 2109011 1205 247.32 4.73 0.00 4.21 0.00 4039056 33 84.65 4724735 2102603 1053 247.32 After the patch InMpps OMpps InGbs OGbs err TCP Est %CPU syscalls csw irq GBfree 5.43 0.00 4.20 0.00 3313143 33 84.96 5434214 1900162 2656 245.51 5.43 0.00 4.20 0.00 3308527 33 85.24 5439695 1809382 2521 245.51 5.42 0.00 4.19 0.00 3316778 33 87.54 5416028 1805835 2256 245.51 5.42 0.00 4.19 0.00 3317673 33 90.44 5426044 1763056 2332 245.51 5.42 0.00 4.19 0.00 3314839 33 88.11 5435732 1792218 2499 245.52 5.44 0.00 4.19 0.00 3293228 33 91.84 5426301 1668597 2121 245.52 Similarly, netperf reports 230Mb/s before the patch, and 270Mb/s after the patch Reviewed by: gallatin Sponsored by: Limelight Networks Differential Revision: https://reviews.freebsd.org/D15366 Notes: svn path=/head/; revision=333813
* Fix bxe(4) netdump rx polling.Mark Johnston2018-05-091-1/+1
| | | | | | | | | Reviewed by: cem, rstone X-MFC with: r333287 Sponsored by: Dell EMC Isilon Notes: svn path=/head/; revision=333429
* Add netdump support to bxe(4).Mark Johnston2018-05-061-0/+59
| | | | | | | | | | | | Tested with a NetXtreme II BCM57810 adapter. Reviewed by: davidcs MFC after: 1 month Sponsored by: Dell EMC Isilon Differential Revision: https://reviews.freebsd.org/D15257 Notes: svn path=/head/; revision=333287
* Fix Issue with adding MUltiCast Addresses. When multicast addresses areDavid C Somayajulu2018-04-251-41/+63
| | | | | | | | | | | added/deleted, the delete the multicast addresses previously programmed in HW and reprogram the new set of multicast addresses. Submitted by:Vaishali.Kulkarni@cavium.com MFC after:5 days Notes: svn path=/head/; revision=333004
* dev/bxe: make use of mallocarray(9).Pedro F. Giffuni2018-01-101-1/+2
| | | | | | | | Use mallocarray in a couple of cases where a calloc-like operation is taking place. Notes: svn path=/head/; revision=327782
* sys/dev: further adoption of SPDX licensing ID tags.Pedro F. Giffuni2017-11-201-0/+2
| | | | | | | | | | | | | | | | | Mainly focus on files that use BSD 3-Clause license. The Software Package Data Exchange (SPDX) group provides a specification to make it easier for automated tools to detect and summarize well known opensource licenses. We are gradually adopting the specification, noting that the tags are considered only advisory and do not, in any way, superceed or replace the license texts. Special thanks to Wind River for providing access to "The Duke of Highlander" tool: an older (2014) run over FreeBSD tree was useful as a starting point. Notes: svn path=/head/; revision=326022
* Add HPE FlexFabric 10Gb 4-port 536FLR-T device id to the bxe(4) driver.Andrey V. Elsukov2017-07-191-0/+6
| | | | | | | | | Tested by: David Miguel Almas <dmalmas gmail com> MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D11478 Notes: svn path=/head/; revision=321203
* 1. state checks in bxe_tx_mq_start_locked() and bxe_tx_mq_start() to sync ↵David C Somayajulu2017-02-271-80/+238
| | | | | | | | | | | | | | | threads during interface down or detach. 2. add sysctl to set pause frame parameters 3. increase max segs for TSO packets to BXE_TSO_MAX_SEGMENTS (32) 4. add debug messages for PHY 5. HW LRO support restricted to FreeBSD versions 8.x and above. Submitted by:Vaishali.Kulkarni@cavium.com MFC after:5 days Notes: svn path=/head/; revision=314365
* bxe: enable usage with NetXtreme II BCM57840 2x20GbE chipRoger Pau Monné2017-02-151-0/+6
| | | | | | | | | | | | | | | Current bxe probe function won't attach to devices with the NetXtreme II BCM57840 2x20GbE chip, enable it by adding it's chip ID to the list of supported chips. Tested on: HP ProLiant WS460c Gen9 Reviewed by: gnn MFC after: 1 week Sponsored by: Citrix Systems R&D Differential Revision: https://reviews.freebsd.org/D9609 Notes: svn path=/head/; revision=313771
* r266979 missed a call to enable capabilities of the hw leading to anSean Bruno2016-11-051-0/+1
| | | | | | | | | | | inability to enable features of the device. PR: 213845 Submitted by: pherman@frenchfries.net MFC after: 1 week Notes: svn path=/head/; revision=308343
* Use proper if_getdrvflags() API.Bryan Drewery2016-10-251-2/+2
| | | | | | | | | This is a NOP. Sponsored by: Dell EMC Isilon Notes: svn path=/head/; revision=307897
* 1. Use taskqueue_create() instead of taskqueue_create_fast() for bothDavid C Somayajulu2016-10-181-96/+94
| | | | | | | | | | | | | | | fastpath and slowpath taskqueues. 2. Service all transmits in taskqueue threads. 3. additional stats counters for keeping track of - bd availability - tx buf ring not emptied in the fp task queue. These are drained via timeout taskqueue. - tx attempts during link down. MFC after: 5 days Notes: svn path=/head/; revision=307578
* Revert commitDavid C Somayajulu2016-09-301-96/+69
| | | | | | | | | r306284 - Fixes for issues under high workloads Will fix and recommit patch Notes: svn path=/head/; revision=306515
* Fixes for issues under high workloadsDavid C Somayajulu2016-09-231-69/+96
| | | | | | | MFC after:5 days Notes: svn path=/head/; revision=306284
* sys/dev: replace comma with semicolon when pertinent.Pedro F. Giffuni2016-08-091-1/+1
| | | | | | | | | | | | | Uses of commas instead of a semicolons can easily go undetected. The comma can serve as a statement separator but this shouldn't be abused when statements are meant to be standalone. Detected with devel/coccinelle following a hint from DragonFlyBSD. MFC after: 1 month Notes: svn path=/head/; revision=303891
* Don't enqueue NULL on a drbrRyan Stone2016-08-081-1/+2
| | | | | | | | | | | | | | | | In one corner case in the bxe TX path, a NULL mbuf could be enqueued onto a drbr queue. This could case a KASSERT to fire with INVARIANTS enabled, or the processing of packets from the queue to be prematurely ended later on. Submitted by: Matt Joras (matt.joras AT isilon.com) Reviewed by: davidcs MFC after: 3 days Sponsored by: EMC / Isilon Storage Division Differential Revision: https://reviews.freebsd.org/D7041 Notes: svn path=/head/; revision=303836
* Don't jam the softc in the device_probe routine. The softc isn't owned byScott Long2016-05-131-7/+0
| | | | | | | | | | | | | | | the driver here, so it shouldn't be accessed, let alone written to. Remove the nearby debug line, it's the only thing that depended on the softc, and it depended on it in a way that couldn't work in this part of the code. This fixes some reports of use-after-free and system instability with DEBUG_MEMGUARD enabled. Submitted by: Matthew Macy MFC after: 3 days Notes: svn path=/head/; revision=299590
* sys/dev: minor spelling fixes.Pedro F. Giffuni2016-05-031-5/+5
| | | | | | | Most affect comments, very few have user-visible effects. Notes: svn path=/head/; revision=298955
* Remove Unused/Dead CodeDavid C Somayajulu2016-04-231-141/+0
| | | | | | | MFC after:5 days Notes: svn path=/head/; revision=298496
generated by cgit v1.2.3 (git 2.25.1) at 2025-08-06 22:45:56 +0000