aboutsummaryrefslogtreecommitdiff
path: root/usr.sbin/fwcontrol
Commit message (Collapse)AuthorAgeFilesLines
* fwcontrol(8): Fix a typo in a messageGordon Bergling2025-10-261-1/+1
| | | | | | - s/verndor/vendor/ MFC after: 1 week
* fwcontrol: Allocate full fw_asyreq structures passed to the kernelJohn Baldwin2024-07-191-4/+4
| | | | | | | | | | | | | | | | The FW_ASYREQ ioctl accepts a struct fw_asyreq object as its argument, meaning that the kernel always copies in the full structure in sys_ioctl before passing the request down to the driver. However, fwcontrol was allocating smaller objects that contained only the request header and a variable-sized payload. This means that the kernel copy in sys_ioctl was reading off the end of this buffer. On current architectures this happened to be ok, but it is UB. Instead, allocate a full structure. Reported by: GCC 14 -Walloc-size Reviewed by: rlibby, brooks Differential Revision: https://reviews.freebsd.org/D46014
* Remove residual blank line at start of MakefileWarner Losh2024-07-151-1/+0
| | | | | | | This is a residual of the $FreeBSD$ removal. MFC After: 3 days (though I'll just run the command on the branches) Sponsored by: Netflix
* Remove $FreeBSD$: two-line nroff patternWarner Losh2023-08-161-2/+0
| | | | Remove /^\.\\"\n\.\\"\s*\$FreeBSD\$$\n/
* Remove $FreeBSD$: one-line sh patternWarner Losh2023-08-162-2/+0
| | | | Remove /^\s*#[#!]?\s*\$FreeBSD\$.*$\n/
* Remove $FreeBSD$: one-line .c patternWarner Losh2023-08-161-1/+0
| | | | Remove /^[\s*]*__FBSDID\("\$FreeBSD\$"\);?\s*\n/
* Remove $FreeBSD$: one-line .h patternWarner Losh2023-08-161-1/+0
| | | | Remove /^\s*\*+\s*\$FreeBSD\$.*$\n/
* Remove $FreeBSD$: two-line .h patternWarner Losh2023-08-162-4/+0
| | | | Remove /^\s*\*\n \*\s+\$FreeBSD\$$\n/
* Update/fix Makefile.depend for userlandSimon J. Gerraty2023-04-191-1/+0
|
* fwcontrol: Disable -Wzero-length-bounds warnings.John Baldwin2022-12-051-0/+1
| | | | | | | | firewire.h includes zero length arrays in unions that trigger this warning. Reviewed by: imp, emaste Differential Revision: https://reviews.freebsd.org/D37538
* fwcontrol: eliminate set but not used warningEd Maste2022-03-101-2/+3
| | | | | | | | | The variable was used in an #if 0 block; just move the variable definition and setting into the same block since Firewire is mainly of historical interest and is unlikely to see ongoing development in FreeBSD. Sponsored by: The FreeBSD Foundation
* fwcontrol: Remove support for FreeBSD 4.xWarner Losh2021-04-202-8/+0
| | | | Sponsored by: Netflix
* Fix various -Wpointer-compare warningsBrooks Davis2019-10-081-1/+1
| | | | | | | | | | | | | | | | | | | | This warning (comparing a pointer against a zero character literal rather than NULL) has existed since GCC 7.1.0, and was recently added to Clang trunk. Almost all of these are harmless, except for fwcontrol's str2node, which needs to both guard against dereferencing a NULL pointer (though in practice it appears none of the callers will ever pass one in), as well as ensure it doesn't parse the empty string as node 0 due to strtol's awkward interface. Submitted by: James Clarke <jtrc27@jrtc27.com> Obtained from: CheriBSD Sponsored by: DARPA, AFRL Differential Revision: https://reviews.freebsd.org/D21914 Notes: svn path=/head/; revision=353326
* Don't close fd twice. This line should have been deleted in r327279.Warner Losh2018-01-051-1/+0
| | | | | | | CID: 1384015 Notes: svn path=/head/; revision=327571
* Close fd when we're done dv-sending the file.Warner Losh2017-12-281-0/+1
| | | | | | | CID: 978413 Notes: svn path=/head/; revision=327279
* spdx: initial adoption of licensing ID tags.Pedro F. Giffuni2017-11-183-3/+9
| | | | | | | | | | | | | | | | | | | | The Software Package Data Exchange (SPDX) group provides a specification to make it easier for automated tools to detect and summarize well known opensource licenses. We are gradually adopting the specification, noting that the tags are considered only advisory and do not, in any way, superceed or replace the license texts. Special thanks to Wind River for providing access to "The Duke of Highlander" tool: an older (2014) run over FreeBSD tree was useful as a starting point. Initially, only tag files that use BSD 4-Clause "Original" license. RelNotes: yes Differential Revision: https://reviews.freebsd.org/D13133 Notes: svn path=/head/; revision=325966
* DIRDEPS_BUILD: Update dependencies.Bryan Drewery2017-10-311-1/+0
| | | | | | | Sponsored by: Dell EMC Isilon Notes: svn path=/head/; revision=325188
* usr.sbin: normalize paths using SRCTOP-relative paths or :H when possibleEnji Cooper2017-03-041-2/+2
| | | | | | | | | | This simplifies make logic/output MFC after: 1 month Sponsored by: Dell EMC Isilon Notes: svn path=/head/; revision=314659
* Fix a ton of speelling errorsEitan Adler2015-10-211-1/+1
| | | | | | | | | | arc lint is helpful Reviewed By: allanjude, wblock, #manpages, chris@bsdjunk.com Differential Revision: https://reviews.freebsd.org/D3337 Notes: svn path=/head/; revision=289677
* Add META_MODE support.Simon J. Gerraty2015-06-131-0/+19
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | Off by default, build behaves normally. WITH_META_MODE we get auto objdir creation, the ability to start build from anywhere in the tree. Still need to add real targets under targets/ to build packages. Differential Revision: D2796 Reviewed by: brooks imp Notes: svn path=/head/; revision=284345
| * dirdeps.mk now sets DEP_RELDIRSimon J. Gerraty2015-06-081-2/+0
| | | | | | | | Notes: svn path=/projects/bmake/; revision=284172
| * Merge head from 7/28Simon J. Gerraty2014-08-191-3/+3
| |\ | |/ |/| | | Notes: svn path=/projects/bmake/; revision=270164
| * Updated dependenciesSimon J. Gerraty2014-05-161-1/+0
| | | | | | | | Notes: svn path=/projects/bmake/; revision=266219
| * Updated dependenciesSimon J. Gerraty2014-05-101-0/+2
| | | | | | | | Notes: svn path=/projects/bmake/; revision=265802
| * Updated dependenciesSimon J. Gerraty2013-03-111-0/+1
| | | | | | | | Notes: svn path=/projects/bmake/; revision=248169
| * Updated dependenciesSimon J. Gerraty2013-02-161-2/+0
| | | | | | | | Notes: svn path=/projects/bmake/; revision=246868
| * Sync from headSimon J. Gerraty2012-11-041-1/+1
| |\ | | | | | | | | | Notes: svn path=/projects/bmake/; revision=242545
| * | Sync FreeBSD's bmake branch with Juniper's internal bmake branch.Marcel Moolenaar2012-08-221-0/+20
| | | | | | | | | | | | | | | | | | | | | Requested by: Simon Gerraty <sjg@juniper.net> Notes: svn path=/projects/bmake/; revision=239572
* | | use .Mt to mark up email addresses consistently (part2)Baptiste Daroussin2014-06-201-3/+3
| |/ |/| | | | | | | | | | | | | PR: 191174 Submitted by: Franco Fichtner <franco@lastsummer.de> Notes: svn path=/head/; revision=267668
* | mdoc: add missing width argument to Bl -tag.Joel Dahl2012-06-031-1/+1
|/ | | | Notes: svn path=/head/; revision=236500
* mdoc: terminate quoted strings.Joel Dahl2012-03-261-3/+3
| | | | | | | Reviewed by: brueffer Notes: svn path=/head/; revision=233510
* Spelling fixes for usr.sbin/Ulrich Spörlein2011-12-302-2/+2
| | | | Notes: svn path=/head/; revision=228990
* - Remove extraneous null ptr deref checksEitan Adler2011-12-211-2/+1
| | | | | | | | | | | - Fix memory leak Submitted by: Slono Slono <slonoman2011@yandex.ru> Approved by: jhb MFC after: 1 week Notes: svn path=/head/; revision=228790
* Quiet clang warnings by using literal format strings for printf-likeEd Maste2011-01-042-3/+3
| | | | | | | functions. Notes: svn path=/head/; revision=216948
* Closing fd when it's doneKevin Lo2010-12-091-0/+1
| | | | | | | Reviewed by: sbruno Notes: svn path=/head/; revision=216321
* Spelling fixes.Joel Dahl2010-08-011-1/+1
| | | | Notes: svn path=/head/; revision=210723
* Always assign WARNS using ?=Ulrich Spörlein2010-03-021-1/+1
| | | | | | | | | | - fix some nearby style bugs - include Makefile.inc where it makes sense and reduces duplication Approved by: ed (co-mentor) Notes: svn path=/head/; revision=204585
* Remove reference to phy_delay from fwcontrol. Thanks for the catch!Sean Bruno2009-02-171-2/+1
| | | | | | | | Submitted by: Giorgos Keramidas <keramida@ceid.upatras.gr> MFC after: 2 weeks Notes: svn path=/head/; revision=188742
* Begin basic improvements to fwcontrol in the area of handlingSean Bruno2009-02-022-13/+12
| | | | | | | | | | | | video streams from cameras. This patch changes the displayed timer to a time stamp and corrects one or two mishandled errors. Submitted by: imp Notes: svn path=/head/; revision=188029
* Add fd = -1 after close when we detect the format so that subsequentWarner Losh2009-01-021-0/+1
| | | | | | | open_dev will reopen the device. Notes: svn path=/head/; revision=186696
* Reviewed by: (Dieter)freebsd@sopwith.solgatos.comSean Bruno2008-12-122-22/+68
| | | | | | | | | | | | | | | Approved by: slong scottl@samsco.org MFC after: 2 weeks Final cleanup of fwcontrol. NetBSD compatibility Cleanup errors in usage() display Finish up error handling via errx/warnx Generate error on unparsed command line syntax Change device(devbase) to open into the form /dev/fwX.X Notes: svn path=/head/; revision=185996
* Sweep this man page a bit:Daniel Gerzo2008-09-111-15/+25
| | | | | | | | | | | - new sentence = new line - use .Dq macro to quote words - some minor rewording MFC after: 2 weeks Notes: svn path=/head/; revision=182948
* Beginning of overhaul of fwcontrol:Sean Bruno2008-09-102-124/+383
| | | | | | | | | | | | | | | | | | | | | - Documentation of send_phy_config() - cleanup of malloc's() and added error checking throughout - new capability to iterate over multiple firewire buses - update usage() display - cleanup command line parsing to allow out of order switches - cleanup command line parsing to allow multiple switches per invocation - cleanup grammar of man page a bit - add some ranges to the man page to indicate what values are valid Since fwcontrol's code is the same across 6/7/head this can be applied to all branches after the MFC period. Reviewed by: Dieter freebsd@sopwith.solgatos.com Approved by: mentor Scott scottl@samsco.org MFC after: 60 days Notes: svn path=/head/; revision=182911
* - add '-f' option to force root node.Hidetoshi Shimokawa2008-03-052-8/+23
| | | | | | | | | | | - fix byte order in read_write_quad() - show hostnames in the list - fix typo in manpage MFC after: 1 week Notes: svn path=/head/; revision=176810
* Remove dublicate .Pp, sort SEE ALSO.Christian Brueffer2007-10-311-4/+3
| | | | Notes: svn path=/head/; revision=173214
* Whitespace-only change: trim EOL spaces.Giorgos Keramidas2007-10-301-3/+3
| | | | Notes: svn path=/head/; revision=173196
* mdoc warning fix: delete spurious empty line.Giorgos Keramidas2007-10-301-2/+1
| | | | | | | MFC after: 3 days Notes: svn path=/head/; revision=173195
* Increase buffer size of DV stream to prevent bufferHidetoshi Shimokawa2007-06-171-1/+1
| | | | | | | | | overrun caused by long blocking of file I/O (i.e. zfs). MFC after: 3 days Notes: svn path=/head/; revision=170878
* Fix a group of typos:Yaroslav Tykhiy2006-12-291-1/+1
| | | | | | | | | | | preceed -> precede, preceeded -> preceded, preceeding -> preceding. Submitted by: Andre Guibert de Bruet <andy@siliconlandmark.com> Notes: svn path=/head/; revision=165628
* Add MPEG2-TS/HDV support to fwcontrol.Warner Losh2006-10-266-56/+464
| | | | | | | | | Submitted by: Petr Holub" <hopet@ics.muni.cz> Clean up by: mi@ Pr: 98134 Notes: svn path=/head/; revision=163712